Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply argument on illegal module access for inline tests if Java version is at least 9. #2022

Merged
merged 1 commit into from Aug 24, 2020

Conversation

raphw
Copy link
Member

@raphw raphw commented Aug 24, 2020

Build fails on Java 8 since the command line option is not supported there.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #2022 into release/3.x will decrease coverage by 0.38%.
The diff coverage is 78.76%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2022      +/-   ##
=================================================
- Coverage          85.28%   84.89%   -0.39%     
- Complexity          2591     2702     +111     
=================================================
  Files                322      325       +3     
  Lines               7483     8192     +709     
  Branches             892      979      +87     
=================================================
+ Hits                6382     6955     +573     
- Misses               862      968     +106     
- Partials             239      269      +30     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/AdditionalAnswers.java 95.00% <ø> (ø) 19.00 <0.00> (ø)
src/main/java/org/mockito/MockedStatic.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...in/java/org/mockito/internal/MockedStaticImpl.java 78.66% <0.00%> (+1.95%) 11.00 <0.00> (+2.00)
.../creation/bytebuddy/SubclassBytecodeGenerator.java 83.47% <0.00%> (-0.70%) 24.00 <0.00> (ø)
...reation/bytebuddy/inject/MockMethodDispatcher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ito/internal/invocation/InterceptedInvocation.java 76.59% <0.00%> (-5.23%) 25.00 <0.00> (ø)
...ternal/invocation/finder/AllInvocationsFinder.java 87.50% <0.00%> (-12.50%) 4.00 <0.00> (ø)
...ockito/internal/util/reflection/InstanceField.java 39.28% <0.00%> (-6.55%) 8.00 <0.00> (ø)
.../main/java/org/mockito/plugins/MemberAccessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ernal/configuration/InjectingAnnotationEngine.java 89.13% <37.50%> (-6.00%) 14.00 <0.00> (+1.00) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a91f0...f48b98a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants