From e7e73e7922c49c4dab5e5d68d4321d5960de1954 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 17 May 2021 09:53:12 +0000 Subject: [PATCH 1/2] Bump versions.errorprone from 2.6.0 to 2.7.1 Bumps `versions.errorprone` from 2.6.0 to 2.7.1. Updates `error_prone_core` from 2.6.0 to 2.7.1 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](https://github.com/google/error-prone/compare/v2.6.0...v2.7.1) Updates `error_prone_test_helpers` from 2.6.0 to 2.7.1 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](https://github.com/google/error-prone/compare/v2.6.0...v2.7.1) Signed-off-by: dependabot[bot] --- gradle/dependencies.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle index eb1b7dd9c3..f8d85a7f73 100644 --- a/gradle/dependencies.gradle +++ b/gradle/dependencies.gradle @@ -6,7 +6,7 @@ def versions = [:] versions.bytebuddy = '1.11.0' versions.junitJupiter = '5.7.2' -versions.errorprone = '2.6.0' +versions.errorprone = '2.7.1' libraries.junit4 = 'junit:junit:4.13.2' libraries.junitJupiterApi = "org.junit.jupiter:junit-jupiter-api:${versions.junitJupiter}" From 187473c280b0e3d60fee7b8c114562191384eb63 Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Mon, 17 May 2021 17:24:20 +0100 Subject: [PATCH 2/2] Fix ErrorProne warnings --- .../bugs/InheritedGenericsPolimorphicCallTest.java | 6 +++--- .../mockitousage/stubbing/StubbingWithCustomAnswerTest.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/mockitousage/bugs/InheritedGenericsPolimorphicCallTest.java b/src/test/java/org/mockitousage/bugs/InheritedGenericsPolimorphicCallTest.java index fed37f92b4..69cde9101c 100644 --- a/src/test/java/org/mockitousage/bugs/InheritedGenericsPolimorphicCallTest.java +++ b/src/test/java/org/mockitousage/bugs/InheritedGenericsPolimorphicCallTest.java @@ -43,7 +43,7 @@ public void shouldStubbingWork() { @Test public void shouldVerificationWorks() { - iterable.iterator(); + MyIterator unused = iterable.iterator(); verify(iterable).iterator(); verify((Iterable) iterable).iterator(); @@ -70,8 +70,8 @@ public Object invoke(Object proxy, Method method, Object[] args) handler); // when - iterable.iterator(); - ((Iterable) iterable).iterator(); + MyIterator unused = iterable.iterator(); + Iterator unused2 = ((Iterable) iterable).iterator(); // then assertEquals(2, methods.size()); diff --git a/src/test/java/org/mockitousage/stubbing/StubbingWithCustomAnswerTest.java b/src/test/java/org/mockitousage/stubbing/StubbingWithCustomAnswerTest.java index bbbaa8a077..5591bc47b5 100644 --- a/src/test/java/org/mockitousage/stubbing/StubbingWithCustomAnswerTest.java +++ b/src/test/java/org/mockitousage/stubbing/StubbingWithCustomAnswerTest.java @@ -40,7 +40,7 @@ public void shouldAnswerWithThenAnswerAlias() throws Exception { RecordCall recordCall = new RecordCall(); Set mockedSet = (Set) when(mock(Set.class).isEmpty()).then(recordCall).getMock(); - mockedSet.isEmpty(); + boolean unused = mockedSet.isEmpty(); assertTrue(recordCall.isCalled()); }