Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes error message less misleading and points to github for help. Issue #2692 #2693

Merged
merged 2 commits into from Jun 25, 2022

Conversation

dstango
Copy link
Contributor

@dstango dstango commented Jun 25, 2022

Small changes to some error messages, that might help users not to search in the wrong place for the cause of an issue.

- makes the proposed error reason less narrow
- points to check the stack trace
- changes suggestion to get assistance from mailing list to GitHub
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #2693 (2bdc29c) into main (70e16dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2693   +/-   ##
=========================================
  Coverage     86.27%   86.27%           
  Complexity     2777     2777           
=========================================
  Files           315      315           
  Lines          8335     8335           
  Branches       1037     1037           
=========================================
  Hits           7191     7191           
  Misses          873      873           
  Partials        271      271           
Impacted Files Coverage Δ
...ByteBuddyCrossClassLoaderSerializationSupport.java 69.76% <ø> (ø)
...on/bytebuddy/InlineDelegateByteBuddyMockMaker.java 68.06% <ø> (ø)
...creation/bytebuddy/SubclassByteBuddyMockMaker.java 71.62% <ø> (ø)
...va/org/mockito/internal/runners/RunnerFactory.java 78.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e16dc...2bdc29c. Read the comment docs.

@dstango dstango closed this Jun 25, 2022
@dstango dstango reopened this Jun 25, 2022
@TimvdLippe TimvdLippe merged commit 3f9ea84 into mockito:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants