Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate ProxyMaker class #1024

Closed
3 tasks done
aSemy opened this issue Jan 15, 2023 · 0 comments · Fixed by #1025
Closed
3 tasks done

De-duplicate ProxyMaker class #1024

aSemy opened this issue Jan 15, 2023 · 0 comments · Fixed by #1025

Comments

@aSemy
Copy link
Contributor

aSemy commented Jan 15, 2023 •
edited

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Current Behavior

There are two almost identical instances of ProxyMaker

https://github.com/mockk/mockk/blob/1419517e0de42c6148d0fb325467d16797ed3e53/modules/mockk-agent-api/src/jvmMain/kotlin/io/mockk/proxy/common/ProxyMaker.kt

https://github.com/mockk/mockk/blob/1419517e0de42c6148d0fb325467d16797ed3e53/modules/mockk-agent/src/jvmMain/kotlin/io/mockk/proxy/jvm/ProxyMaker.kt

Expected Behavior

These classes should be de-duplicated

Context

  • MockK version: 1.13.3

Related:
@aSemy aSemy changed the title Deduplicate ProxyMaker class De-duplicate ProxyMaker class Jan 15, 2023
@aSemy aSemy mentioned this issue Jan 15, 2023
Merged
@GFriedrich GFriedrich mentioned this issue Jan 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-duplicate ProxyMaker aSemy/mockk
1 participant
@aSemy