Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue that Android libraries was not published #887

Merged
merged 2 commits into from Aug 23, 2022

Conversation

kubode
Copy link
Contributor

@kubode kubode commented Aug 23, 2022

Fixes: #883

The official Android documentation about publications is here.

I confirmed that mockk-android is published with the following command.

$ ./gradlew publishToMavenLocal
$ tree ~/.m2/repository/io/mockk/
~/.m2/repository/io/mockk
├── mockk
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-1.12.7-SNAPSHOT-kotlin-tooling-metadata.json
│   │   ├── mockk-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-1.12.7-SNAPSHOT.module
│   │   └── mockk-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-agent
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-agent-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-agent-1.12.7-SNAPSHOT-kotlin-tooling-metadata.json
│   │   ├── mockk-agent-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-agent-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-agent-1.12.7-SNAPSHOT.module
│   │   └── mockk-agent-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-agent-android
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-agent-android-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-agent-android-1.12.7-SNAPSHOT.aar
│   │   ├── mockk-agent-android-1.12.7-SNAPSHOT.module
│   │   └── mockk-agent-android-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-agent-api
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-agent-api-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-agent-api-1.12.7-SNAPSHOT-kotlin-tooling-metadata.json
│   │   ├── mockk-agent-api-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-agent-api-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-agent-api-1.12.7-SNAPSHOT.module
│   │   └── mockk-agent-api-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-agent-api-jvm
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-agent-api-jvm-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-agent-api-jvm-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-agent-api-jvm-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-agent-api-jvm-1.12.7-SNAPSHOT.module
│   │   └── mockk-agent-api-jvm-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-agent-jvm
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-agent-jvm-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-agent-jvm-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-agent-jvm-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-agent-jvm-1.12.7-SNAPSHOT.module
│   │   └── mockk-agent-jvm-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-android
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-android-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-android-1.12.7-SNAPSHOT.aar
│   │   ├── mockk-android-1.12.7-SNAPSHOT.module
│   │   └── mockk-android-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-dsl
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-dsl-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-dsl-1.12.7-SNAPSHOT-kotlin-tooling-metadata.json
│   │   ├── mockk-dsl-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-dsl-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-dsl-1.12.7-SNAPSHOT.module
│   │   └── mockk-dsl-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── mockk-dsl-jvm
│   ├── 1.12.7-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── mockk-dsl-jvm-1.12.7-SNAPSHOT-javadoc.jar
│   │   ├── mockk-dsl-jvm-1.12.7-SNAPSHOT-sources.jar
│   │   ├── mockk-dsl-jvm-1.12.7-SNAPSHOT.jar
│   │   ├── mockk-dsl-jvm-1.12.7-SNAPSHOT.module
│   │   └── mockk-dsl-jvm-1.12.7-SNAPSHOT.pom
│   └── maven-metadata-local.xml
└── mockk-jvm
    ├── 1.12.7-SNAPSHOT
    │   ├── maven-metadata-local.xml
    │   ├── mockk-jvm-1.12.7-SNAPSHOT-javadoc.jar
    │   ├── mockk-jvm-1.12.7-SNAPSHOT-sources.jar
    │   ├── mockk-jvm-1.12.7-SNAPSHOT.jar
    │   ├── mockk-jvm-1.12.7-SNAPSHOT.module
    │   └── mockk-jvm-1.12.7-SNAPSHOT.pom
    └── maven-metadata-local.xml

20 directories, 72 files

publications.withType<MavenPublication>().configureEach {
createMockKPom {
name.set(provider { mavenName })
description.set(provider { mavenDescription })
}

artifact(tasks.provider<Jar>("javadocJar"))
artifact(tasks.provider<Task>("javadocJar"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is that the following error occurs.

> The task 'javadocJar' (org.gradle.jvm.tasks.Jar) is not a subclass of the given type (org.gradle.api.tasks.bundling.Jar).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to have been caused by importing org.gradle.jvm.tasks.Jar in android-library.gradle.kts.
Removing import from android-library.gradle.kts solved the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 23, 2022

Brilliant, thanks a lot!

@Raibaz Raibaz merged commit ae698e2 into mockk:master Aug 23, 2022
kodiakhq bot pushed a commit to RBusarow/Dispatch that referenced this pull request Aug 23, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.mockk:mockk](https://mockk.io) ([source](https://togithub.com/mockk/mockk)) | `1.12.5` -> `1.12.7` | [![age](https://badges.renovateapi.com/packages/maven/io.mockk:mockk/1.12.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.mockk:mockk/1.12.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.mockk:mockk/1.12.7/compatibility-slim/1.12.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.mockk:mockk/1.12.7/confidence-slim/1.12.5)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>mockk/mockk</summary>

### [`v1.12.7`](https://togithub.com/mockk/mockk/releases/tag/1.12.7)

[Compare Source](https://togithub.com/mockk/mockk/compare/1.12.6...1.12.7)

#### What's Changed

-   Update android-sdk-detector.settings.gradle.kts by [@&#8203;aSemy](https://togithub.com/aSemy) in [mockk/mockk#886
-   only sign if the signing properties are present by [@&#8203;aSemy](https://togithub.com/aSemy) in [mockk/mockk#885
-   Fix an issue that Android libraries was not published by [@&#8203;kubode](https://togithub.com/kubode) in [mockk/mockk#887

#### New Contributors

-   [@&#8203;kubode](https://togithub.com/kubode) made their first contribution in [mockk/mockk#887

**Full Changelog**: mockk/mockk@1.12.6...1.12.7

### [`v1.12.6`](https://togithub.com/mockk/mockk/releases/tag/1.12.6)

[Compare Source](https://togithub.com/mockk/mockk/compare/1.12.5...1.12.6)

#### What's Changed

-   Dependency updates, JDK17 v2 by [@&#8203;aSemy](https://togithub.com/aSemy) in [mockk/mockk#863
-   Dependency updates, JDK17 by [@&#8203;hduerkop](https://togithub.com/hduerkop) in [mockk/mockk#829
-   Fix unmockkAll to work if constructor was mocked multiple times by [@&#8203;Chrostoq](https://togithub.com/Chrostoq) in [mockk/mockk#870
-   fix: fix value class field determination by [@&#8203;qoomon](https://togithub.com/qoomon) in [mockk/mockk#872
-   [#&#8203;854](https://togithub.com/mockk/mockk/issues/854) update projects to use new Kotlin Multiplatform Gradle plugin by [@&#8203;aSemy](https://togithub.com/aSemy) in [mockk/mockk#855

#### New Contributors

-   [@&#8203;hduerkop](https://togithub.com/hduerkop) made their first contribution in [mockk/mockk#829
-   [@&#8203;Chrostoq](https://togithub.com/Chrostoq) made their first contribution in [mockk/mockk#870

**Full Changelog**: mockk/mockk@1.12.5...1.12.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/RBusarow/Dispatch).



PR-URL: #564
@kubode kubode deleted the kubode/fix_android_publishing branch August 24, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockk-android:1.12.6 is not published
3 participants