Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle isValue exceptions #890

Merged
merged 1 commit into from Aug 24, 2022
Merged

fix: handle isValue exceptions #890

merged 1 commit into from Aug 24, 2022

Conversation

qoomon
Copy link
Contributor

@qoomon qoomon commented Aug 23, 2022

No description provided.

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 24, 2022

Not a big fan of catching Throwable.

Can we provide explicit casts for each exception type?

@qoomon
Copy link
Contributor Author

qoomon commented Aug 24, 2022

I'm not either :-), however the known exceptions, that need to be catched are kotlin. UnsupportedOperationException andkotlin.reflect.jvm.internal.KotlinReflectionInternalError. Unfortunately KotlinReflectionInternalError is an internal Error. Technically I want to catch Exceptions and Errors, but that is Throwable in the end :-(

@qoomon
Copy link
Contributor Author

qoomon commented Aug 24, 2022

If it is okay I could catch kotlin.reflect.jvm.internal.KotlinReflectionInternalError and UnsupportedOperationException just for the jvm package and keep the other catch blocks as they are, just catching UnsupportedOperationException

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 24, 2022

Yep this looks much better, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants