Fix an issue that Android Instrumentation Test fails #895

kubode · 2022-08-24T09:36:05Z

To fix #894.

modules/mockk-agent-android/build.gradle.kts

kubode · 2022-08-24T09:51:11Z

After checking at hand, another problem arises.
I will look into it a bit.

java.lang.IllegalAccessError: Illegal class access: 'kotlin.sequences.SequencesKt__SequencesKt' attempting to access 'kotlin.sequences.GeneratorSequence' (declaration of 'kotlin.sequences.SequencesKt__SequencesKt' appears in /data/app/~~YbK6coZSvv0ODMk3y0Y_Uw==/myapp.debug-pj9V59qD4OtzIPJvj2zhxg==/base.apk!classes33.dex)
at kotlin.sequences.SequencesKt__SequencesKt.generateSequence(Sequences.kt:641)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation.computeProperties(DeserializedMemberScope.kt:623)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation.access$computeProperties(DeserializedMemberScope.kt:228)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation$properties$1.invoke(DeserializedMemberScope.kt:253)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation$properties$1.invoke(DeserializedMemberScope.kt:253)
at kotlin.reflect.jvm.internal.impl.storage.LockBasedStorageManager$MapBasedMemoizedFunction.invoke(LockBasedStorageManager.java:578)
at kotlin.reflect.jvm.internal.impl.storage.LockBasedStorageManager$MapBasedMemoizedFunctionToNotNull.invoke(LockBasedStorageManager.java:651)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation.getContributedVariables(DeserializedMemberScope.kt:338)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope$OptimizedImplementation.addFunctionsAndPropertiesTo(DeserializedMemberScope.kt:352)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedMemberScope.computeDescriptors(DeserializedMemberScope.kt:115)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedClassDescriptor$DeserializedClassMemberScope$allDescriptors$1.invoke(DeserializedClassDescriptor.kt:301)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedClassDescriptor$DeserializedClassMemberScope$allDescriptors$1.invoke(DeserializedClassDescriptor.kt:300)
at kotlin.reflect.jvm.internal.impl.storage.LockBasedStorageManager$LockBasedLazyValue.invoke(LockBasedStorageManager.java:408)
at kotlin.reflect.jvm.internal.impl.storage.LockBasedStorageManager$LockBasedNotNullLazyValue.invoke(LockBasedStorageManager.java:527)
at kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedClassDescriptor$DeserializedClassMemberScope.getContributedDescriptors(DeserializedClassDescriptor.kt:311)
at kotlin.reflect.jvm.internal.impl.resolve.scopes.ResolutionScope$DefaultImpls.getContributedDescriptors$default(ResolutionScope.kt:50)
at kotlin.reflect.jvm.internal.KDeclarationContainerImpl.getMembers(KDeclarationContainerImpl.kt:56)
at kotlin.reflect.jvm.internal.KClassImpl$Data$declaredNonStaticMembers$2.invoke(KClassImpl.kt:162)
at kotlin.reflect.jvm.internal.KClassImpl$Data$declaredNonStaticMembers$2.invoke(KClassImpl.kt:162)
at kotlin.reflect.jvm.internal.ReflectProperties$LazySoftVal.invoke(ReflectProperties.java:93)
at kotlin.reflect.jvm.internal.ReflectProperties$Val.getValue(ReflectProperties.java:32)
at kotlin.reflect.jvm.internal.KClassImpl$Data.getDeclaredNonStaticMembers(KClassImpl.kt:162)
at kotlin.reflect.jvm.internal.KClassImpl$Data$allNonStaticMembers$2.invoke(KClassImpl.kt:171)
at kotlin.reflect.jvm.internal.KClassImpl$Data$allNonStaticMembers$2.invoke(KClassImpl.kt:171)
at kotlin.reflect.jvm.internal.ReflectProperties$LazySoftVal.invoke(ReflectProperties.java:93)
at kotlin.reflect.jvm.internal.ReflectProperties$Val.getValue(ReflectProperties.java:32)
at kotlin.reflect.jvm.internal.KClassImpl$Data.getAllNonStaticMembers(KClassImpl.kt:171)
at kotlin.reflect.full.KClasses.getMemberProperties(KClasses.kt:148)
at io.mockk.impl.annotations.JvmMockInitializer.initMock(JvmMockInitializer.kt:40)
at io.mockk.impl.annotations.JvmMockInitializer.initAnnotatedMocks(JvmMockInitializer.kt:24)
at MyTest.setUp(MyTest.kt:672)

kubode · 2022-08-24T10:17:37Z

The size of dispatcher.jar is much larger than in 1.12.5.

This contains unnecessary class files.
This is because android-application.gradle.kts, which applies the Kotlin plugin, adds a Kotlin dependency to the agent-android app.

…aining unnecessary classes

kubode · 2022-08-24T10:21:55Z

It is fixed at f770509.
I have confirmed that testing with 1.12.8-SNAPSHOT on my local is successful.

kubode · 2022-08-24T10:38:33Z

modules/mockk-agent-android-dispatcher/build.gradle.kts

@@ -3,15 +3,24 @@ import buildsrc.config.asProvider
 import com.android.build.gradle.internal.tasks.DexMergingTask

 plugins {
-    buildsrc.convention.`android-application`
+    id("com.android.application")


I removed android-application.gradle.kts since it is not used except for android-dispatcher module.
Instead, I moved the contents of android-application.gradle.kts to this build.gradle.kts.

It's intentional that build config that is shareable is defined in buildSrc, even if it's only used in one place. It helps keep the build logic organised and consistent. It makes it easier to compare and contrast the Android Library config to the Android Application config, and easier to see if there's any special treatment that's needed in the subprojects. So I think this should be reverted.

IMHO, I think it is better to remove android-application.gradle.kts.
:mockk-agent-android-dispatcher module is a very specific Android Application module that only extracts the final DEX file, and the build configuration is completely independent and non-reusable.
If we were to add an Android sample application module in the future and try to reuse the configuration with :mockk-agent-android-dispatcher module, it would add an unnecessary dependency to :mockk-agent-android-dispatcher module and cause the same problems that encountered in this PR.

Yeah, I think the dependency on :mockk-agent-android-dispatcher should be removed from the buildSrc script

edit: I read your comment too quickly and my response doesn't make sense! I'll have another look

aSemy · 2022-08-24T18:55:26Z

Do you know if there's a good way to write an automated test for this?

kubode · 2022-08-25T04:40:42Z

How about adding a verification task to make sure that the :mockk-agent-android-dispatcher module has no Kotlin dependencies?

By the way, it seems that there is already an Android Instrumentation Test for :mockk-android, but it doesn't seem to be working on either my local or CI.

https://github.com/mockk/mockk/runs/7992536177?check_suite_focus=true

> Task :modules:mockk-agent-android:connectedDebugAndroidTest
Starting 0 tests on test(AVD) - 8.0.0

I was getting the following error on my local.
It looks like I need to migrate Android Instrumentation Test.
I will try that migration.

2022-08-25 11:28:33.300 12901-12901/io.mockk.proxy.android.test E/AndroidRuntime: FATAL EXCEPTION: main
    Process: io.mockk.proxy.android.test, PID: 12901
    java.lang.RuntimeException: Unable to instantiate instrumentation ComponentInfo{io.mockk.proxy.android.test/android.support.test.runner.AndroidJUnitRunner}: java.lang.ClassNotFoundException: Didn't find class "android.support.test.runner.AndroidJUnitRunner" on path: DexPathList[[zip file "/data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/base.apk"],nativeLibraryDirectories=[/data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/lib/arm64, /data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/base.apk!/lib/arm64-v8a, /system/lib64, /system_ext/lib64]]
        at android.app.ActivityThread.initInstrumentation(ActivityThread.java:6939)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6723)
        at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2134)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7898)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "android.support.test.runner.AndroidJUnitRunner" on path: DexPathList[[zip file "/data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/base.apk"],nativeLibraryDirectories=[/data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/lib/arm64, /data/app/~~yFm1Ji-ZgakvYB21oPnWpw==/io.mockk.proxy.android.test-pCFrw66KOowBzyq5tw_P3w==/base.apk!/lib/arm64-v8a, /system/lib64, /system_ext/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at android.app.ActivityThread.initInstrumentation(ActivityThread.java:6935)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6723) 
        at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2134) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loopOnce(Looper.java:201) 
        at android.os.Looper.loop(Looper.java:288) 
        at android.app.ActivityThread.main(ActivityThread.java:7898) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

…dispatcher

kubode · 2022-08-25T06:03:33Z

buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts

+    androidTestImplementation(kotlin("test"))
+    androidTestImplementation(kotlin("test-junit"))
+}
+


📝I thought it would be better to make the test configs common, so I moved them here.

kubode · 2022-08-25T06:06:16Z

buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts

+    }
+
+    testOptions {
+        execution = "ANDROIDX_TEST_ORCHESTRATOR"


📝 Using Test Orchestrator makes Instrumentation Test stable. Documentation

kubode · 2022-08-25T06:06:43Z

modules/mockk-android/build.gradle.kts

-
-    defaultConfig {
-        testInstrumentationRunner = "android.support.test.runner.AndroidJUnitRunner"
-        testInstrumentationRunnerArguments["notAnnotation"] = "io.mockk.test.SkipInstrumentedAndroidTest"


📝This class was not included in the test APK and an error log was displayed, so I remove this notAnnotation config.

kubode · 2022-08-25T06:08:21Z

...es/mockk-android/src/androidTest/java/io/mockk/proxy/android/AndroidMockKAgentFactoryTest.kt

-    @Rule
-    @JvmField
-    val rule = ActivityTestRule(TestActivity::class.java)


📝 Removed because it's unnecessary.

Raibaz · 2022-08-25T21:25:51Z

@kubode thanks a lot for putting this together. Is this complete? Can we merge it?

aSemy · 2022-08-25T21:29:11Z

@kubode thanks a lot for putting this together. Is this complete? Can we merge it?

I'd like the changes to the buildSrc convention plugin to be reversed, the original problems were fixed in #899

kubode · 2022-08-26T04:28:35Z

#899 does not resolve all issues.
The IllegalAccessError issue remains. (See #895 (comment))
My opinion on the IllegalAccessError is #895 (comment).

Or should I revert the convention plugin and fix the convention plugin so that the IllegalAccessError does not occur?

aSemy · 2022-08-26T06:24:10Z

#899 does not resolve all issues. The IllegalAccessError issue remains. (See #895 (comment)) My opinion on the IllegalAccessError is #895 (comment).

Or should I revert the convention plugin and fix the convention plugin so that the IllegalAccessError does not occur?

good point! Can you revert the convention plugin changes, then apply the specific fixes to the subproject's build.gradle.kts

kubode · 2022-08-26T06:49:44Z

good point! Can you revert the convention plugin changes, then apply the specific fixes to the subproject's build.gradle.kts

It is possible, however in that case we need to remove Kotlin plugins from the android-application convention plugin.
Are you okay with this way?

aSemy · 2022-08-26T07:19:42Z

Remove kapt and allopen, right? Yeah, go ahead.

mockk/buildSrc/src/main/kotlin/buildsrc/convention/android-library.gradle.kts

Lines 9 to 10 in b72cf14

    
           kotlin("kapt") 
        
           kotlin("plugin.allopen")

kubode · 2022-08-26T07:34:25Z

Fixed!
Also removed kotlin("android") because IllegalAccessError error occurs.

aSemy · 2022-08-26T07:42:02Z

Ah okay, I thought that kotlin("jvm") was necessary. I think this is how it was applied before the Kotlin Multiplatform plugin and buildSrc convention plugins updates

mockk/plugins/configuration/src/main/kotlin/io/mockk/configuration/AndroidConfigurationPlugin.kt

Lines 32 to 37 in 1d1e6a8

    
           apply<KotlinAndroidPluginWrapper>() 
        
           extensions.configure(KotlinAndroidProjectExtension::class) { 
        
               sourceSets["main"].dependencies { 
        
                   implementation(Deps.Libs.kotlinStdLib(kotlinVersion())) 
        
               } 
        
           }

But if it's not necessary, then it can be removed.

kubode · 2022-08-26T07:54:57Z

In agent/android/dispatcher/build.gradle.kts of version 1.12.5, no Kotlin plugin is applied at all.
https://github.com/mockk/mockk/blob/1.12.5/agent/android/dispatcher/build.gradle.kts
So it is correct not to apply the Kotlin plugin.

aSemy · 2022-08-26T07:58:20Z

Ah good point, I got confused between mockk-android and mockk-agent-android-dispatcher

# Conflicts: # modules/mockk-android/build.gradle.kts

Fix an issue that Android Instrumentation Test fails

f9a22af

To fix mockk#894.

kubode commented Aug 24, 2022

View reviewed changes

modules/mockk-agent-android/build.gradle.kts Outdated Show resolved Hide resolved

kubode marked this pull request as draft August 24, 2022 09:45

Fix Android Instrumentation Test failure due to dispatcher.jar cont…

f770509

…aining unnecessary classes

kubode marked this pull request as ready for review August 24, 2022 10:22

kubode commented Aug 24, 2022

View reviewed changes

aSemy mentioned this pull request Aug 24, 2022

Fix Android Instrumentation dispatcher.jar inclusion #899

Merged

kubode added 3 commits August 25, 2022 14:20

Fix Android Instrumentation Test not working

d9bb509

Merge branch 'kubode/fix_android_test' into kubode/fix_android_fails_…

47f470e

…dispatcher

Migrate to AndroidX Test suite

2e186ea

kubode commented Aug 25, 2022

View reviewed changes

Raibaz closed this in #899 Aug 25, 2022

kubode added 2 commits August 25, 2022 16:52

Merge branch 'master' into kubode/fix_android_fails_dispatcher

e364606

Fix a merge conflict

b64549f

Raibaz reopened this Aug 25, 2022

kubode added 2 commits August 26, 2022 13:09

Reverts android-application.gradle.kts

eedb520

Merge branch 'master' into kubode/fix_android_fails_dispatcher

c18440f

kubode added 2 commits August 26, 2022 16:25

Re-apply android-application plugin to android-dispatcher

244b334

Remove wrong Jar task import

3275c3b

Merge branch 'master' into kubode/fix_android_fails_dispatcher

afcfc2d

# Conflicts: # modules/mockk-android/build.gradle.kts

Raibaz merged commit 6c571a6 into mockk:master Aug 29, 2022

aSemy mentioned this pull request Aug 29, 2022

Version 1.12.7 build failed #909

Closed

kubode deleted the kubode/fix_android_fails_dispatcher branch August 30, 2022 02:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an issue that Android Instrumentation Test fails #895

Fix an issue that Android Instrumentation Test fails #895

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode Aug 24, 2022 •

edited

aSemy Aug 24, 2022

kubode Aug 24, 2022

aSemy Aug 24, 2022 •

edited

aSemy commented Aug 24, 2022

kubode commented Aug 25, 2022

kubode Aug 25, 2022

kubode Aug 25, 2022

kubode Aug 25, 2022

kubode Aug 25, 2022

Raibaz commented Aug 25, 2022

aSemy commented Aug 25, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

Fix an issue that Android Instrumentation Test fails #895

Fix an issue that Android Instrumentation Test fails #895

Conversation

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode commented Aug 24, 2022

kubode Aug 24, 2022 • edited

Choose a reason for hiding this comment

aSemy Aug 24, 2022

Choose a reason for hiding this comment

kubode Aug 24, 2022

Choose a reason for hiding this comment

aSemy Aug 24, 2022 • edited

Choose a reason for hiding this comment

aSemy commented Aug 24, 2022

kubode commented Aug 25, 2022

kubode Aug 25, 2022

Choose a reason for hiding this comment

kubode Aug 25, 2022

Choose a reason for hiding this comment

kubode Aug 25, 2022

Choose a reason for hiding this comment

kubode Aug 25, 2022

Choose a reason for hiding this comment

Raibaz commented Aug 25, 2022

aSemy commented Aug 25, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode commented Aug 26, 2022

aSemy commented Aug 26, 2022

kubode Aug 24, 2022 •

edited

aSemy Aug 24, 2022 •

edited