Fix Android Instrumentation dispatcher.jar inclusion #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 I think it's better than before because it is less buggy and less hard-coding 👍 |
|
Nice, thanks! |
|
@Raibaz |
|
Sure, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894
My take on #895 - credit to @kubode for identifying the problem and showing how to check it.
What do you think @kubode?
It also includes using the Gradle task output - this helps with Gradle task optimisation. Wrapping the task in a lambda prevents the NPE.
The issue in this comment is also resolved #895 (comment)