introduce Kotlinx Benchmark tests (copied from #763) #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tmszdmsk) refactor test projects to be in separate directory
aSemy
changed the title
Raibaz
reviewed
Aug 25, 2022
…seconds per test seems quite long, more iterations is better)
|
I added some additional tests for context, and used https://jmh.morethan.io/ to visualise the results.
I don't think it's a surprise that the test without mocking/stubbing is very fast, but as commented here the stub decreases the operations, even though the stub isn't called. |
|
Yep makes sense, as discussed in #13 the most expensive part is actually creating stubs rather than using them. |
|
I think this PR can be merged in as-is. It's a good basis for future work, be it making the code better, or adding a GHA or visualizer plugin https://github.com/jzillmann/gradle-jmh-report |
|
Yep I think the next steps about this would be adding a GHA to monitor performances and track potential hits. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copied from #763 - credit to @tmszdmsk!
I thought this was a good change, and I'm curious about investigating #13 and I think these benchmark tests can help.
I also refactored the existing 'client tests' to be in a new 'test modules' directory, because I think it's neater and more organised to have the test projects together, rather than mixed amongst the 'regular' projects.