fix(test-runner-mocha): move @types/mocha to dev dependency

Having an `@types/*` package with global symbols like `it` and `describe` forces these global types on downstream consumers which may not use them. For example, Jasmine types overlap and conflict with Mocha types, but transitively including `@types/mocha` through `@web/test-runner-mocha` makes Jasmine impossible to use with Web Test Runner. See [this commit](angular/angular-cli@d95bb63) for a motivating example.
modernweb-dev · Oct 31, 2023 · 60dda46 · 60dda46
1 parent 5a81704
commit 60dda46
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/twenty-pants-draw.md b/.changeset/twenty-pants-draw.md
@@ -0,0 +1,5 @@
+---
+'@web/test-runner-mocha': patch
+---
+
+Remove `@types/mocha` from dependencies so its global types don't leak into user code.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/test-runner-mocha/package.json b/packages/test-runner-mocha/package.json
@@ -35,10 +35,10 @@
     "framework"
   ],
   "dependencies": {
-    "@types/mocha": "^10.0.1",
     "@web/test-runner-core": "^0.11.1"
   },
   "devDependencies": {
+    "@types/mocha": "^10.0.1",
     "deepmerge": "^4.2.2",
     "mocha": "^10.2.0"
   }