Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Mongo database names #3191

Open
1 of 2 tasks
Vedinsoh opened this issue Sep 20, 2022 · 3 comments · May be fixed by #3279
Open
1 of 2 tasks

Allow custom Mongo database names #3191

Vedinsoh opened this issue Sep 20, 2022 · 3 comments · May be fixed by #3279
Labels
feature request priority: low Something that's not on top of the list. You are free to submit a pull request though

Comments

@Vedinsoh
Copy link
Contributor

Vedinsoh commented Sep 20, 2022

Is your feature request related to a problem? Please elaborate.

Currently database name seems to be hardcoded in clients.py. It's a bit tedious to change modmail_bot strings in clients.py every time. This issue is especially apparent for those of us who run multiple modmail instances on the same machine, in our case it's different bot instances for different languages we support.

Describe the solution you'd like

Perhaps add support for either database names in CONNECTION_URI in .env (mongodb+srv://mongodburi/database_name) (default to modmail_bot if none provided)

Does your solution involve any of the following?

  • Logviewer
  • New config option

Describe alternatives you've considered

Alternatively make a new .env param such as DATABASE_NAME

Who will this benefit?

People who run more than one instance of modmail bot on the same database, or people who prefer to have better configurability.

Additional Information

No response

@ririko5834
Copy link

Or it should get the database from the mongo uri provided in .env

@Vedinsoh
Copy link
Contributor Author

Or it should get the database from the mongo uri provided in .env

That would probably be the best, I agree.

@StephenDaDev StephenDaDev added the priority: low Something that's not on top of the list. You are free to submit a pull request though label Mar 14, 2023
@StephenDaDev
Copy link
Member

I put this as low priority because we may implement this in the future (no promises) but its not a high priority at this point.

@Hackerjef Hackerjef linked a pull request Apr 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request priority: low Something that's not on top of the list. You are free to submit a pull request though
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants