Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add the field multiselect #143

Open
OlegShchavelev opened this issue Apr 14, 2018 · 7 comments · Fixed by modxcms/revolution#16404
Open

Please add the field multiselect #143

OlegShchavelev opened this issue Apr 14, 2018 · 7 comments · Fixed by modxcms/revolution#16404

Comments

@OlegShchavelev
Copy link

Thank you for completing the package and solving issue # 61. We also ask you to expand the possibilities and add a new type of the multiselect field
@Mark-H
Copy link
Member

Mark-H commented Apr 14, 2018

Hey @DetaliDigital - what sort of use cases for this do you have in mind?

@Mark-H
Copy link
Member

Mark-H commented Jul 6, 2018

Ideas on use cases would still be welcome, that way it can be made sure that it's implemented the right way.

@hugopeek
Copy link

Possible use case would be to choose which social media channels to include in a toolbar with sharing options. It seems to be mentioned here too: #32

I think using checkboxes would be the most straightforward way. Similar to how Checkbox TVs work: give them some input options like Twitter||Facebook||LinkedIn||GooglePlus||Pinterest and output a comma separated list of selected items.

@belong2me
Copy link

This is a very necessary option

@labr1005
Copy link

It would also be nice to have "Process tags in options" to dynamically populate the options with a chunk or snippet.

+1 for checkboxes

@Spheerys
Copy link

Spheerys commented Jun 15, 2019 •
edited

Another usecase : my client has a food truck and each morning she had to configure on his website (propulsed with Commerce, of course) which desserts will be avaible for the day : Apple pie||Brownie||Icecream

I'm also confirm than a checkbox view will be the most straightforward way (and not a multi-select list)
And such all the desserts are resources on MODX, it could be also very usefull to get a "Process tags in options".

@Mark-H Mark-H mentioned this issue Oct 24, 2019
Open
Mark-H added a commit that referenced this issue Oct 24, 2019
@Mark-H
Attempt adding a multi checkbox field #143
fbee00d
@Mark-H Mark-H mentioned this issue Oct 24, 2019
Open
@Mark-H
Copy link
Member

Mark-H commented Oct 24, 2019

I've tried to add this but am running into a js error I've not seen before and limited time to continue on it right now. In-progress at #176

@sebastian-marinescu sebastian-marinescu mentioned this issue Feb 27, 2023
Merged
@sebastian-marinescu sebastian-marinescu mentioned this issue Sep 4, 2023
Merged
opengeek added a commit to modxcms/revolution that referenced this issue Mar 22, 2024
@sebastian-marinescu @opengeek
Add guard-clause to clearDirty method (#16467)
3446d08 
### What does it do?
This makes sure the JS doesn't throw an error in the case that the
items-object is an array, just like in
#16404 for 3.x

### Why is it needed?
When using ExtJS to create components of the xtype: 'radiogroup' to be
used in CMPs inside a form,
this function gets called and tries to iterate over it's items array
with a method that doesn't exist.

This PR isn't changing the way forms or the clearDirty-method are
handled, it just assures no error is thrown when using
radiogroup-components.

### Related issue(s)/PR(s)
Resolves modmore/ClientConfig#202
Resolves modmore/ClientConfig#176
Resolves modmore/ClientConfig#143

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add guard-clause to clearDirty method sebastian-marinescu/revolution
6 participants
@Mark-H @labr1005 @Spheerys @hugopeek @belong2me @OlegShchavelev