You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a minor one :) ... My OCD goes a little bit off when I have to do this when configuring all your wonderful packages (typescript setup):
import { ModuleFederationPlugin } from '@module-federation/enhanced';
import { FederatedTypesPlugin } from '@module-federation/typescript';
import { NativeFederationTestsRemote } from '@module-federation/native-federation-tests';
const moduleFederationConfig = {// config here}
new ModuleFederationPlugin(moduleFederationConfig),
new FederatedTypesPlugin({ federationConfig: moduleFederationConfig }),
NativeFederationTestsRemote.webpack({ moduleFederationConfig }),
Suggested solution
I would love to have the interfaces aligned and be able to do:
import { ModuleFederationPlugin } from '@module-federation/enhanced';
import { FederatedTypesPlugin } from '@module-federation/typescript';
import { NativeFederationTestsRemote } from '@module-federation/native-federation-tests/webpack';
const moduleFederationConfig = {// config here}
new ModuleFederationPlugin({ moduleFederationConfig }),
new FederatedTypesPlugin({ moduleFederationConfig }),
new NativeFederationTestsRemote({ moduleFederationConfig }),
This will, in my eyes, make it a bit more streamlined to use for us consumers.
And just to spell it out :) some plugins expect a key like "federationConfig", while others expect "moduleFederationConfig". Some requires instantiation (new Plugin() vs Plugin()). The exact naming is not so important, as log as its aligned.
Clear and concise description of the problem
This is a minor one :) ... My OCD goes a little bit off when I have to do this when configuring all your wonderful packages (typescript setup):
Suggested solution
I would love to have the interfaces aligned and be able to do:
This will, in my eyes, make it a bit more streamlined to use for us consumers.
And just to spell it out :) some plugins expect a key like "federationConfig", while others expect "moduleFederationConfig". Some requires instantiation (new Plugin() vs Plugin()). The exact naming is not so important, as log as its aligned.
Alternative
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: