Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquoted %JAVACMD% in Windows script crashes at runtime if %JAVACMD% contains whitespaces #114

Open
sebjulliand opened this issue Dec 18, 2020 · 0 comments

Comments

@sebjulliand
Copy link

sebjulliand commented Dec 18, 2020

Here in the Windows script, %JAVACMD% is unquoted:

%JAVACMD% %JAVA_OPTS%  -classpath %CLASSPATH% -Dapp.name="skipper" -Dapp.repo="%REPO%" -Dapp.home="%BASEDIR%" -Dbasedir="%BASEDIR%" com.arcadsoftware.skipper.cli.SkipperCLI %CMD_LINE_ARGS%
if %ERRORLEVEL% NEQ 0 goto error
goto end

It causes the script to crash if %JAVACMD% contains whitespaces. E.g.: C:\Program Files\Java\jdk8u252-b09\bin\java.exe

sebjulliand added a commit to sebjulliand/appassembler that referenced this issue Dec 18, 2020
This prevents the Windows script from crashing if %JAVACMD% contains whitespace.
sebjulliand added a commit to sebjulliand/appassembler that referenced this issue Dec 18, 2020
This prevents the Windows script from crashing if %JAVACMD% contains whitespace.
sebjulliand added a commit to sebjulliand/appassembler that referenced this issue Dec 18, 2020
Fixes mojohaus#114 - Unquoted %JAVACMD% in Windows script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant