-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cobertura 2.1.1 uses slf4j binding logback-classic #36
Comments
I can exclude logback-classic from the cobertura dependency but then I run into other problems because there's then no slf4j binding when the test projects are run. If I skip the tests it then fails to run on my project because the slf4j binding it uses only works on Android platforms. It looks like Cobertura either needs to stop using slf4j or Maven needs to segregate the plugin dependencies from the project dependencies. |
Is there any solution to this issue at all? |
…ndency. - Updated Java version to 1.7. - Restructured Maven projects in order to create easy to consume "cobertura.jar" Core Library. - Moved web (coberturaFlush.war) files to it's own module, called cobertura-flush-war. This project build war package and contains only servlet class, test classes, and needed web.xml configuration. - Moved final stand-alone tool creation to new cobertura-assembly module. This maven (pom) project is only responsible for building tool's packge (in zip, tar, etc. format) that includes Cobertura Core library, Cobertura Flush Servlet WAR, and all needed dependencies as well as scripts, examples and (logback) logging configuration. - Re-factored pom.xml to proper structure and inheritance. Cobertura 2.1.1 uses slf4j binding logback-classic cobertura#36 mojohaus/cobertura-maven-plugin#36
These changes require corresponding changes in coberura. - Changed Cobertura logging configuration file to logback and included logback SLF4J binding for runtime scope. The use of logback was not really necessary and Log4J would of worked to as long as binding library is provided. I chose logback to be consitent with how Cobertura stand-alone tool works. - Updated the necessary code to use the new configuration file. - Updated maven requirements to 3.3.1 - Partial update of maven API versions to 3.x (mojohaus#32 Update to maven 3 apis ) - Cobertura-plugin 2.7 modifies the build's log4j configuration mojohaus#36 mojohaus#32 mojohaus#14
More changes related to maven API versions to 3.x that fix unit and integration tests. The actual production code still needs to be adapted to 3.x API. mojohaus#32 Update to maven 3 apis
Just to add some context to how important fixing this bug is, there is a StackOverflow question illustrating that Cobertura 2.1.1 forces wire logging for Apache Commons HttpClient, which can easily cripple a Jenkins server. |
Cobertura 2.1.1 uses the slf4j binding logback-classic, which causes problems when the project has a different slf4j binding:
This binding should be removed, leaving only slf4j-api.
Please DO NOT propose workarounds, those are in the closed issue #6.
The text was updated successfully, but these errors were encountered: