Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Enum class failed to comply with Fortify SCA #55

Open
mh888 opened this issue Sep 6, 2017 · 1 comment
Open

Generated Enum class failed to comply with Fortify SCA #55

mh888 opened this issue Sep 6, 2017 · 1 comment

Comments

@mh888
Copy link

mh888 commented Sep 6, 2017

For Enum generated from simpletype of wsdl, the java class generated failed to comply with Fortify SCA as the major complain is that there is a private String value and there is a method value() also -- Poor Style: Confusing Naming. We are using latest version 2.4.1. See the sample below:

@XmlType(name = "XYZ")
@XmlEnum
public enum XYZ {
//omit other stuff
private final String value;

XYZ(String v) {
    value = v;
}

public String value() {
    return value;
}

}

In wsdl, section is
<s:simpleType name="XYZ">
<s:restriction base="s:string">
<s:enumeration value="A"/>
<s:enumeration value="B"/>
<s:enumeration value="C"/>
</s:restriction>
</s:simpleType>

Please provide advice.

Thanks.

@phax
Copy link

phax commented Sep 6, 2017

Fine as it is. Auto generated code. Disable the warning in Fortify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants