Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not include transitive inczip dependencies #64

Open
jbrentnell opened this issue Sep 11, 2022 · 0 comments
Open

Plugin does not include transitive inczip dependencies #64

jbrentnell opened this issue Sep 11, 2022 · 0 comments

Comments

@jbrentnell
Copy link

When using the plugin building libraries that depend on other libraries, the plugin does not find transitive inczip files.

I believe that is because the NativeUnZipIncMojo.getIncZipDependencies() method calls getDependencyArtifacts() on the Maven project. That method returns direct dependencies. I believe it should call getArtifacts(), which also returns transitive dependencies, instead.

I have not had time to test my theory. I will be doing that soon.

I really appreciate this plugin. It is making my life much better doing C++ builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant