New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket zlib calls aren’t error-checked #1935

Open

FGasper opened this issue Apr 11, 2022 · 0 comments

FGasper commented Apr 11, 2022

mojo/lib/Mojo/Transaction/WebSocket.pm

Lines 30 to 31 in 89182e4

    
           $deflate->deflate($frame->[5], my $out); 
        
           $deflate->flush($out, Z_SYNC_FLUSH);

mojo/lib/Mojo/Transaction/WebSocket.pm

Line 96 in 89182e4

$inflate->inflate(($msg .= "\x00\x00\xff\xff"), my $out);

We aren’t sure, but this may be related to some zlib memory-handling errors we’ve seen that may relate to the recent Zlib CVE.

I’m not sure how failures should be reported here, but these seem like calls that should be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment