Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent navigation when event was cancelled #239

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Prevent navigation when event was cancelled #239

merged 1 commit into from
Mar 31, 2022

Conversation

Tomas2D
Copy link
Contributor

@Tomas2D Tomas2D commented Mar 18, 2022

Issue described in #237

@Tomas2D
Copy link
Contributor Author

Tomas2D commented Mar 22, 2022

ping @molefrog

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you @Tomas2D!

I've left some minor comments and suggestions.

@Tomas2D Tomas2D requested a review from molefrog March 31, 2022 12:00
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #239 (9e5edeb) into master (cba34af) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #239   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          250       251    +1     
  Branches        50        51    +1     
=========================================
+ Hits           250       251    +1     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba34af...9e5edeb. Read the comment docs.

@molefrog molefrog merged commit 467d8b2 into molefrog:master Mar 31, 2022
@molefrog
Copy link
Owner

Thanks for your contribution @Tomas2D!

I'm going to work on releasing the stable 2.8.0 and mention you in the changelog when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants