Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors when skipLibCheck is false #887

Open
lo1tuma opened this issue Nov 1, 2023 · 0 comments
Open

TypeScript errors when skipLibCheck is false #887

lo1tuma opened this issue Nov 1, 2023 · 0 comments

Comments

@lo1tuma
Copy link

lo1tuma commented Nov 1, 2023

I’ve noticed the d2c starter-kit sets the ts option skipLibCheck to true. No I’ve tried to use the moltin sdk in a different project where we haven’t set skipLibCheck to true and I get around 40 compile errors when running the typescript compile, all complain about the moltin.d.ts in the node_modules folder.

E.g.:

node_modules/@moltin/sdk/dist/moltin.d.ts:98:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

Is there any chance that you fix those errors, so we don’t have to disable lib check as this would degrade the accuracy of the type-system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant