Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings.defaultWeekSettings not working #1570

Open
aronsuarez opened this issue Jan 14, 2024 · 1 comment
Open

Settings.defaultWeekSettings not working #1570

aronsuarez opened this issue Jan 14, 2024 · 1 comment

Comments

@aronsuarez
Copy link

Describe the bug
Settings.defaultWeekSettings has no effect at all, the weeks are starting still at Sunday

To Reproduce
Settings.defaultLocale = 'de-CH'
Settings.defaultWeekSettings = { firstDay: 1, minimalDays: 1, weekend: [6, 7] }

Actual vs Expected behavior
I want to set default start day of the week to monday, currently is nothing changed when i set the Settings.defaultWeekSettings

Desktop (please complete the following information):

  • OS: Android, iOS, MacOS (all latest)
  • Browser Chrome and Safari Latest
  • Luxon version 3.4.4
  • Your timezone Europe/Zurich

Additional context
Add any other context about the problem here.

@diesieben07
Copy link
Collaborator

In my tests this works correctly. Are you setting useLocaleWeeks when using startOf? startOf('week') on its own always uses the ISO week year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants