-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package-lock.json's version does not match package.json's #799
Comments
I noticed this while working on a different PR: #797 (comment). Also, @GillesDebunne's comment #794 (comment) made me notice that there is an My suggestion is to use I will be creating a PR now based on this suggestion, for further analysis by the maintainers. |
I created https://github.com/moment/luxon/pull/800/files to use it as a reference. There are some problems involved, such as:
|
For a less bold approach, the exported VERSION variable is now hardcoded. Meanwhile, the `scripts/tag` script was improved to ensure that all versions match. See moment#800 (comment). Resolves moment#747 and moment#799.
For a less bold approach, the exported VERSION variable is now hardcoded. Meanwhile, the `scripts/tag` script was improved to ensure that all versions match. See moment#800 (comment). Resolves moment#747 and resolves moment#799.
It would be ideal to have the version on
package-lock.json
matchingpackage.json
's.It seems to be missing as a part of the release creation.
luxon/package.json
Line 3 in 345b1cd
luxon/package-lock.json
Line 3 in 345b1cd
The text was updated successfully, but these errors were encountered: