Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moment-timezone prefers to declare itself as an amd style module #572

Closed
CharlesWall opened this issue Jan 16, 2018 · 2 comments
Closed

Comments

@CharlesWall
Copy link

Moment-timezone first checks to see if define is a "function" then checks to see if it is being declared in a module by checking for exports. This is not ideal. In situations (like mine) where your code ends up in a place where window.define is set and you are requiring moment-timezone as a node style dependency, the require returns an empty object and causes subsequent errors.

@CharlesWall
Copy link
Author

CharlesWall commented Jan 17, 2018

I added a PR that fixes this issue. PR#573

There are four failing tests, but I get the same failures on master and develop.

@gilmoreorless
Copy link
Member

I see from #573 that this was released in 0.5.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants