[feature] Add localeSort param to Locale weekday methods #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icambron
reviewed
Apr 16, 2018
| @@ -35,6 +35,9 @@ function weekdaysCaseReplace(m, format) { | |||
| 'genitive': 'неділі_понеділка_вівторка_середи_четверга_п’ятниці_суботи'.split('_') | |||
| }; | |||
|
|
|||
| if (m === true) { | |||
| return weekdays['nominative'].slice(1, 7).concat(weekdays['nominative'].slice(0, 1)); | |||
| } | |||
| if (!m) { | |||
icambron
approved these changes
Apr 16, 2018
This was referenced Jan 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4066
This adds
Locale#weekdays(true)to sort weekdays by locale (asmoment.weekdays(true)does if it is the current locale). Same for#weekdaysShort,#weekdaysMin.I added some tests for all locales, and a concrete one for
en-au.Example: