Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn.tz keepTime argument is not documented. #586

Closed
wtfcarlos opened this issue Jul 25, 2018 · 2 comments
Closed

fn.tz keepTime argument is not documented. #586

wtfcarlos opened this issue Jul 25, 2018 · 2 comments
Labels
Up-For-Grabs

Comments

@wtfcarlos
Copy link

The functionality added in moment/moment-timezone#505 is not mentioned anywhere in the documentation.
@mattjohnsonpint mattjohnsonpint transferred this issue from moment/moment-timezone Jul 9, 2019
@mattjohnsonpint
Copy link
Contributor

Indeed. The optional second parameter to the tz instance function is not documented. It's behavior is similar to the optional second parameter to the utcOffset instance function, so the wording should match closely.

See also https://stackoverflow.com/a/56957999/634824

@marwahaha marwahaha mentioned this issue May 13, 2020
Closed
@marwahaha
Copy link
Member

It's (lightly) documented here:
https://momentjs.com/timezone/docs/#/using-timezones/converting-to-zone/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Up-For-Grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wtfcarlos @mattjohnsonpint @marwahaha