Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3815): update Decimal128 constructor validation #476

Merged
merged 5 commits into from Dec 21, 2021
Merged

fix(NODE-3815): update Decimal128 constructor validation #476

merged 5 commits into from Dec 21, 2021
+51 −6

Conversation

syz99
Copy link
Contributor

@syz99 syz99 commented Dec 16, 2021 •
edited

Description

What is changing?

Add new checkings/exceptions for invalid types

Is there new documentation needed for these changes?

n/a

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@syz99 syz99 self-assigned this Dec 16, 2021
@syz99 syz99 requested review from nbbeeken, dariakp and baileympearson and removed request for nbbeeken and dariakp December 16, 2021 21:26
baileympearson
baileympearson previously requested changes Dec 16, 2021
View reviewed changes
test/node/decimal128_tests.js Outdated Show resolved Hide resolved
test/node/decimal128_tests.js Show resolved Hide resolved
src/bson.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added the Team Review Needs review from team label Dec 20, 2021
nbbeeken
nbbeeken previously approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

durran
durran requested changes Dec 20, 2021
View reviewed changes
test/node/decimal128_tests.js Outdated Show resolved Hide resolved
@nbbeeken nbbeeken removed the request for review from baileympearson December 21, 2021 18:55
@nbbeeken nbbeeken dismissed baileympearson’s stale review December 21, 2021 18:56

Bailey OOO, comments addressed

@nbbeeken nbbeeken merged commit 95e8293 into master Dec 21, 2021
@nbbeeken nbbeeken deleted the NODE-3815/improve-error-message-for-improper-input-quoting branch December 21, 2021 18:56
addaleax added a commit to mongodb-js/compass that referenced this pull request Jan 12, 2022
@addaleax
fix(bson-transpilers): account for bson Decimal128 validation changes
14912d4 
Refs: mongodb/js-bson#476
Refs: https://jira.mongodb.org/browse/NODE-3815
@addaleax addaleax mentioned this pull request Jan 12, 2022
Merged
10 tasks
addaleax added a commit to mongodb-js/compass that referenced this pull request Jan 12, 2022
@addaleax
fix(bson-transpilers): account for bson Decimal128 validation changes (…
0cc8deb 
…#2679)

Refs: mongodb/js-bson#476
Refs: https://jira.mongodb.org/browse/NODE-3815
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson left review comments

Assignees

@syz99 syz99

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@syz99 @durran @nbbeeken @baileympearson