fix(NODE-4302): remove downlevel ts and typesVersions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
added
the
Primary Review
|
@durran I think we can merge this as is and we'll address the windows strangeness in another PR, its an unrelated nvm issue and they pass as long as they're run sequentially. ❓ |
durran
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Remove downlevel-dts and test public types / compiling src against old/current/next TS versions
oldest version is set to TS v4.0.2 (there is no 4.0.0)
What is the motivation for this change?
downlevel-dts isn't providing any needed changes to the types
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>