Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4381): handle __proto__ well in EJSON #506

Merged
merged 3 commits into from Jul 5, 2022
Merged

fix(NODE-4381): handle __proto__ well in EJSON #506

merged 3 commits into from Jul 5, 2022

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Jul 5, 2022

Description

What is changing?

Similar fix and similar test as f34cabc, just for
EJSON serialization instead of BSON deserialization.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Aligning behavior with regular JSON.

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax
fix(NODE-4381): handle __proto__ well in EJSON
0fd0455 
Similar fix and similar test as f34cabc, just for
EJSON serialization instead of BSON deserialization.
nbbeeken
nbbeeken requested changes Jul 5, 2022
View reviewed changes
test/node/extended_json_tests.js Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added the Team Review Needs review from team label Jul 5, 2022
@addaleax addaleax requested a review from nbbeeken July 5, 2022 16:20
nbbeeken
nbbeeken previously approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement to the other test! LGTM

baileympearson
baileympearson previously approved these changes Jul 5, 2022
View reviewed changes
dariakp
dariakp requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small test thing

test/node/extended_json_tests.js Outdated Show resolved Hide resolved
@addaleax addaleax dismissed stale reviews from baileympearson and nbbeeken via 707a941 July 5, 2022 19:37
@addaleax addaleax requested a review from dariakp July 5, 2022 19:37
dariakp
dariakp approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nbbeeken nbbeeken merged commit 4bda57d into main Jul 5, 2022
@nbbeeken nbbeeken deleted the 4381-dev branch July 5, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken left review comments

@baileympearson baileympearson baileympearson left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@addaleax @nbbeeken @baileympearson @dariakp