diff --git a/internal/cli/deployments/connect.go b/internal/cli/deployments/connect.go index 1c3b17be79..8a3aa3ef2f 100644 --- a/internal/cli/deployments/connect.go +++ b/internal/cli/deployments/connect.go @@ -28,6 +28,10 @@ func Run(ctx context.Context, opts *options.ConnectOpts) error { return opts.Connect(ctx) } +func PostRun(opts *options.ConnectOpts) { + opts.DeploymentTelemetry.AppendDeploymentType() +} + // atlas deployments connect [clusterName]. func ConnectBuilder() *cobra.Command { opts := &options.ConnectOpts{} @@ -53,6 +57,9 @@ func ConnectBuilder() *cobra.Command { RunE: func(cmd *cobra.Command, _ []string) error { return Run(cmd.Context(), opts) }, + PostRun: func(_ *cobra.Command, _ []string) { + PostRun(opts) + }, } cmd.Flags().StringVar(&opts.ConnectWith, flag.ConnectWith, "", usage.ConnectWith) diff --git a/internal/cli/deployments/connect_test.go b/internal/cli/deployments/connect_test.go index 19fac849ef..09aaff9384 100644 --- a/internal/cli/deployments/connect_test.go +++ b/internal/cli/deployments/connect_test.go @@ -24,12 +24,11 @@ import ( "github.com/golang/mock/gomock" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/options" - "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/config" + "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/test/fixture" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/flag" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/mocks" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/podman" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/pointer" - "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/store" "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/test" "github.com/stretchr/testify/assert" "go.mongodb.org/atlas-sdk/v20231115008/admin" @@ -43,43 +42,20 @@ const ( func TestRun_ConnectLocal(t *testing.T) { ctrl := gomock.NewController(t) ctx := context.Background() - mockPodman := mocks.NewMockClient(ctrl) buf := new(bytes.Buffer) + deploymenTest := fixture.NewMockLocalDeploymentOpts(ctrl, expectedLocalDeployment) connectOpts := &options.ConnectOpts{ - ConnectWith: "connectionString", - DeploymentOpts: options.DeploymentOpts{ - PodmanClient: mockPodman, - DeploymentName: expectedLocalDeployment, - DeploymentType: "local", - }, + ConnectWith: "connectionString", + DeploymentOpts: *deploymenTest.Opts, OutputOpts: cli.OutputOpts{ OutWriter: buf, }, } - expectedContainers := []*podman.Container{ - { - Names: []string{expectedLocalDeployment}, - State: "running", - Labels: map[string]string{"version": "6.0.9"}, - ID: expectedLocalDeployment, - }, - } - - mockPodman. - EXPECT(). - Ready(ctx). - Return(nil). - Times(1) + deploymenTest.LocalMockFlow(ctx) - mockPodman. - EXPECT(). - ListContainers(ctx, options.MongodHostnamePrefix). - Return(expectedContainers, nil). - Times(1) - - mockPodman. + deploymenTest.MockPodman. EXPECT(). ContainerInspect(ctx, options.MongodHostnamePrefix+"-"+expectedLocalDeployment). Return([]*podman.InspectContainerData{ @@ -122,18 +98,12 @@ func TestRun_ConnectAtlas(t *testing.T) { ctx := context.Background() buf := new(bytes.Buffer) - mockAtlasClusterListStore := mocks.NewMockClusterLister(ctrl) - mockCredentialsGetter := mocks.NewMockCredentialsGetter(ctrl) mockAtlasClusterDescriber := mocks.NewMockClusterDescriber(ctrl) + deploymenTest := fixture.NewMockAtlasDeploymentOpts(ctrl, expectedAtlasDeployment) connectOpts := &options.ConnectOpts{ - ConnectWith: "connectionString", - DeploymentOpts: options.DeploymentOpts{ - AtlasClusterListStore: mockAtlasClusterListStore, - DeploymentName: expectedAtlasDeployment, - DeploymentType: "atlas", - CredStore: mockCredentialsGetter, - }, + ConnectWith: "connectionString", + DeploymentOpts: *deploymenTest.Opts, ConnectToAtlasOpts: options.ConnectToAtlasOpts{ Store: mockAtlasClusterDescriber, GlobalOpts: cli.GlobalOpts{ @@ -161,16 +131,7 @@ func TestRun_ConnectAtlas(t *testing.T) { }, } - mockAtlasClusterListStore. - EXPECT(). - ProjectClusters(connectOpts.ProjectID, - &store.ListOptions{ - PageNum: cli.DefaultPage, - ItemsPerPage: options.MaxItemsPerPage, - }, - ). - Return(expectedAtlasClusters, nil). - Times(1) + deploymenTest.CommonAtlasMocks(connectOpts.ProjectID) mockAtlasClusterDescriber. EXPECT(). @@ -178,12 +139,6 @@ func TestRun_ConnectAtlas(t *testing.T) { Return(&expectedAtlasClusters.GetResults()[0], nil). Times(1) - mockCredentialsGetter. - EXPECT(). - AuthType(). - Return(config.OAuth). - Times(1) - if err := Run(ctx, connectOpts); err != nil { t.Fatalf("Run() unexpected error: %v", err) } @@ -192,6 +147,27 @@ func TestRun_ConnectAtlas(t *testing.T) { `, buf.String()) } +func TestPostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentsTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + buf := new(bytes.Buffer) + + opts := &options.ConnectOpts{ + DeploymentOpts: *deploymentsTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentsTest. + MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + PostRun(opts) +} + func TestConnectBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/delete_test.go b/internal/cli/deployments/delete_test.go index 0e076079f0..094e123f4d 100644 --- a/internal/cli/deployments/delete_test.go +++ b/internal/cli/deployments/delete_test.go @@ -160,7 +160,7 @@ func TestDeleteBuilder(t *testing.T) { ) } -func TestDelete_PostRun(t *testing.T) { +func TestDeleteOpts_PostRun(t *testing.T) { ctrl := gomock.NewController(t) deploymentsTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") buf := new(bytes.Buffer) diff --git a/internal/cli/deployments/list_test.go b/internal/cli/deployments/list_test.go index 310e01f265..7b94078ada 100644 --- a/internal/cli/deployments/list_test.go +++ b/internal/cli/deployments/list_test.go @@ -149,7 +149,7 @@ func TestListBuilder(t *testing.T) { ) } -func TestList_PostRun(t *testing.T) { +func TestListOpts_PostRun(t *testing.T) { ctrl := gomock.NewController(t) buf := new(bytes.Buffer) diff --git a/internal/cli/deployments/logs.go b/internal/cli/deployments/logs.go index 1216c0926a..9c96b8929a 100644 --- a/internal/cli/deployments/logs.go +++ b/internal/cli/deployments/logs.go @@ -181,6 +181,10 @@ func (opts *DownloadOpts) validateAtlasFlags() error { return nil } +func (opts *DownloadOpts) PostRun() { + opts.DeploymentTelemetry.AppendDeploymentType() +} + // atlas deployments logs. func LogsBuilder() *cobra.Command { opts := &DownloadOpts{ @@ -204,6 +208,9 @@ func LogsBuilder() *cobra.Command { RunE: func(cmd *cobra.Command, _ []string) error { return opts.Run(cmd.Context()) }, + PostRun: func(_ *cobra.Command, _ []string) { + opts.PostRun() + }, } cmd.Flags().StringVar(&opts.DeploymentType, flag.TypeFlag, "", usage.DeploymentType) diff --git a/internal/cli/deployments/logs_test.go b/internal/cli/deployments/logs_test.go index 091f28fcb6..f37b153f91 100644 --- a/internal/cli/deployments/logs_test.go +++ b/internal/cli/deployments/logs_test.go @@ -112,3 +112,24 @@ func TestLogs_RunAtlas(t *testing.T) { t.Fatalf("Run() unexpected error: %v", err) } } + +func TestDownloadOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + buf := new(bytes.Buffer) + + opts := &DownloadOpts{ + DeploymentOpts: *deploymentTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentTest. + MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + opts.PostRun() +} diff --git a/internal/cli/deployments/options/deployment_opts.go b/internal/cli/deployments/options/deployment_opts.go index b22cb7a950..858322d664 100644 --- a/internal/cli/deployments/options/deployment_opts.go +++ b/internal/cli/deployments/options/deployment_opts.go @@ -261,5 +261,8 @@ func (opts *DeploymentOpts) IsAuthEnabled() bool { } func (opts *DeploymentOpts) UpdateDeploymentTelemetry() { + if opts.DeploymentTelemetry == nil { + opts.DeploymentTelemetry = NewDeploymentTypeTelemetry(opts) + } opts.DeploymentTelemetry.AppendDeploymentType() } diff --git a/internal/cli/deployments/options/deployment_opts_select.go b/internal/cli/deployments/options/deployment_opts_select.go index be2e6b9faa..14c1180ba8 100644 --- a/internal/cli/deployments/options/deployment_opts_select.go +++ b/internal/cli/deployments/options/deployment_opts_select.go @@ -104,7 +104,7 @@ func (opts *DeploymentOpts) Select(deployments []Deployment) (Deployment, error) opts.DeploymentName = deployments[0].Name opts.DeploymentType = strings.ToLower(deployments[0].Type) - opts.AppendDeploymentType() + opts.UpdateDeploymentTelemetry() return deployments[0], nil } @@ -131,6 +131,6 @@ func (opts *DeploymentOpts) Select(deployments []Deployment) (Deployment, error) deployment := deploymentsByDisplayName[displayName] opts.DeploymentName = deployment.Name opts.DeploymentType = strings.ToLower(deployment.Type) - opts.AppendDeploymentType() + opts.UpdateDeploymentTelemetry() return deployment, nil } diff --git a/internal/cli/deployments/pause.go b/internal/cli/deployments/pause.go index 3fa2c0a88a..f9e24387eb 100644 --- a/internal/cli/deployments/pause.go +++ b/internal/cli/deployments/pause.go @@ -122,6 +122,11 @@ func (opts *PauseOpts) StopMongoD(ctx context.Context, names string) error { return opts.PodmanClient.Exec(ctx, "-d", names, "mongod", "--shutdown") } +func (opts *PauseOpts) PostRun() error { + opts.DeploymentTelemetry.AppendDeploymentType() + return opts.PostRunMessages() +} + func PauseBuilder() *cobra.Command { opts := &PauseOpts{} cmd := &cobra.Command{ @@ -149,9 +154,8 @@ func PauseBuilder() *cobra.Command { } return opts.Run(cmd.Context()) }, - PostRunE: func(_ *cobra.Command, _ []string) error { - return opts.PostRunMessages() + return opts.PostRun() }, } diff --git a/internal/cli/deployments/pause_test.go b/internal/cli/deployments/pause_test.go index 0bdfcccc9a..ba50342937 100644 --- a/internal/cli/deployments/pause_test.go +++ b/internal/cli/deployments/pause_test.go @@ -121,6 +121,28 @@ func TestPause_RunAtlas(t *testing.T) { t.Log(buf.String()) } +func TestPauseOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, deploymentName) + buf := new(bytes.Buffer) + + opts := &PauseOpts{ + DeploymentOpts: *deploymentTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentTest.MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + if err := opts.PostRun(); err != nil { + t.Fatalf("PostRun() unexpected error: %v", err) + } +} + func TestPauseBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/search/indexes/create.go b/internal/cli/deployments/search/indexes/create.go index 504d5e7762..780e77d174 100644 --- a/internal/cli/deployments/search/indexes/create.go +++ b/internal/cli/deployments/search/indexes/create.go @@ -172,6 +172,7 @@ func (opts *CreateOpts) watch(ctx context.Context) (any, bool, error) { } func (opts *CreateOpts) PostRun(ctx context.Context) error { + opts.AppendDeploymentType() if !opts.EnableWatch { return opts.Print(opts.index) } diff --git a/internal/cli/deployments/search/indexes/create_test.go b/internal/cli/deployments/search/indexes/create_test.go index f899193c6c..07cab920b1 100644 --- a/internal/cli/deployments/search/indexes/create_test.go +++ b/internal/cli/deployments/search/indexes/create_test.go @@ -159,7 +159,6 @@ func TestCreate_RunLocal(t *testing.T) { if err := opts.Run(ctx); err != nil { t.Fatalf("Run() unexpected error: %v", err) } - if err := opts.PostRun(ctx); err != nil { t.Fatalf("PostRun() unexpected error: %v", err) } diff --git a/internal/cli/deployments/search/indexes/delete.go b/internal/cli/deployments/search/indexes/delete.go index 64de1a4132..6202217736 100644 --- a/internal/cli/deployments/search/indexes/delete.go +++ b/internal/cli/deployments/search/indexes/delete.go @@ -99,6 +99,10 @@ func (opts *DeleteOpts) initMongoDBClient(ctx context.Context) func() error { } } +func (opts *DeleteOpts) PostRun() { + opts.DeploymentTelemetry.AppendDeploymentType() +} + func DeleteBuilder() *cobra.Command { opts := &DeleteOpts{ DeleteOpts: cli.NewDeleteOpts(deletedMessage, deleteMessageFailed), @@ -127,6 +131,9 @@ func DeleteBuilder() *cobra.Command { return opts.Run(cmd.Context()) }, + PostRun: func(_ *cobra.Command, _ []string) { + opts.PostRun() + }, } cmd.Flags().StringVar(&opts.DeploymentName, flag.DeploymentName, "", usage.DeploymentName) diff --git a/internal/cli/deployments/search/indexes/delete_test.go b/internal/cli/deployments/search/indexes/delete_test.go index ae1a214727..adf93f23e2 100644 --- a/internal/cli/deployments/search/indexes/delete_test.go +++ b/internal/cli/deployments/search/indexes/delete_test.go @@ -147,6 +147,22 @@ func TestDelete_RunAtlas(t *testing.T) { } } +func TestDeleteOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + opts := &DeleteOpts{ + DeploymentOpts: *deploymentTest.Opts, + } + + deploymentTest. + MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + opts.PostRun() +} + func TestDeleteBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/search/indexes/describe.go b/internal/cli/deployments/search/indexes/describe.go index 22f4fe1ef6..45d3be8a7f 100644 --- a/internal/cli/deployments/search/indexes/describe.go +++ b/internal/cli/deployments/search/indexes/describe.go @@ -103,6 +103,10 @@ func (opts *DescribeOpts) initStore(ctx context.Context) func() error { } } +func (opts *DescribeOpts) PostRun() { + opts.DeploymentTelemetry.AppendDeploymentType() +} + func DescribeBuilder() *cobra.Command { opts := &DescribeOpts{} cmd := &cobra.Command{ @@ -129,6 +133,9 @@ func DescribeBuilder() *cobra.Command { } return opts.Run(cmd.Context()) }, + PostRun: func(_ *cobra.Command, _ []string) { + opts.PostRun() + }, } cmd.Flags().StringVar(&opts.DeploymentType, flag.TypeFlag, "", usage.DeploymentType) diff --git a/internal/cli/deployments/search/indexes/describe_test.go b/internal/cli/deployments/search/indexes/describe_test.go index ba96ebc565..7b95fe6fc8 100644 --- a/internal/cli/deployments/search/indexes/describe_test.go +++ b/internal/cli/deployments/search/indexes/describe_test.go @@ -181,6 +181,27 @@ func TestDescribe_RunAtlas(t *testing.T) { } } +func TestDescribeOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + buf := new(bytes.Buffer) + + opts := &DescribeOpts{ + DeploymentOpts: *deploymentTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentTest. + MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + opts.PostRun() +} + func TestDescribeBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/search/indexes/list.go b/internal/cli/deployments/search/indexes/list.go index 88dbcb9e99..8efbecb247 100644 --- a/internal/cli/deployments/search/indexes/list.go +++ b/internal/cli/deployments/search/indexes/list.go @@ -112,6 +112,10 @@ func (opts *ListOpts) validateAndPrompt() error { return nil } +func (opts *ListOpts) PostRun() { + opts.DeploymentTelemetry.AppendDeploymentType() +} + func ListBuilder() *cobra.Command { opts := &ListOpts{} cmd := &cobra.Command{ @@ -135,6 +139,9 @@ func ListBuilder() *cobra.Command { RunE: func(cmd *cobra.Command, _ []string) error { return opts.Run(cmd.Context()) }, + PostRun: func(_ *cobra.Command, _ []string) { + opts.PostRun() + }, } cmd.Flags().StringVar(&opts.DeploymentName, flag.DeploymentName, "", usage.DeploymentName) diff --git a/internal/cli/deployments/search/indexes/list_test.go b/internal/cli/deployments/search/indexes/list_test.go index f13b3d0743..0d5ac0328a 100644 --- a/internal/cli/deployments/search/indexes/list_test.go +++ b/internal/cli/deployments/search/indexes/list_test.go @@ -209,6 +209,26 @@ func TestList_RunAtlas(t *testing.T) { } } +func TestList_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + buf := new(bytes.Buffer) + + opts := &ListOpts{ + DeploymentOpts: *deploymentTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentTest.MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + opts.PostRun() +} + func TestListBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/setup.go b/internal/cli/deployments/setup.go index c44e2ded89..d26b78b1ce 100644 --- a/internal/cli/deployments/setup.go +++ b/internal/cli/deployments/setup.go @@ -823,6 +823,10 @@ func (opts *SetupOpts) Run(ctx context.Context) error { return opts.runAtlas(ctx) } +func (opts *SetupOpts) PostRun() { + opts.DeploymentTelemetry.AppendDeploymentType() +} + // atlas deployments setup. func SetupBuilder() *cobra.Command { opts := &SetupOpts{ @@ -856,6 +860,9 @@ func SetupBuilder() *cobra.Command { RunE: func(cmd *cobra.Command, _ []string) error { return opts.Run(cmd.Context()) }, + PostRun: func(_ *cobra.Command, _ []string) { + opts.PostRun() + }, } // Local and Atlas diff --git a/internal/cli/deployments/setup_test.go b/internal/cli/deployments/setup_test.go new file mode 100644 index 0000000000..4268734881 --- /dev/null +++ b/internal/cli/deployments/setup_test.go @@ -0,0 +1,46 @@ +// Copyright 2023 MongoDB Inc +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +//go:build unit + +package deployments + +import ( + "bytes" + "testing" + + "github.com/golang/mock/gomock" + "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli" + "github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/test/fixture" +) + +func TestSetupOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentTest := fixture.NewMockLocalDeploymentOpts(ctrl, deploymentName) + buf := new(bytes.Buffer) + + opts := &SetupOpts{ + DeploymentOpts: *deploymentTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentTest.MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + opts.PostRun() +} diff --git a/internal/cli/deployments/start.go b/internal/cli/deployments/start.go index 6351b96ae0..e1cf717f0c 100644 --- a/internal/cli/deployments/start.go +++ b/internal/cli/deployments/start.go @@ -121,6 +121,11 @@ func (opts *StartOpts) RunAtlas() error { return opts.Print(r) } +func (opts *StartOpts) PostRun() error { + opts.DeploymentTelemetry.AppendDeploymentType() + return opts.PostRunMessages() +} + func StartBuilder() *cobra.Command { opts := &StartOpts{} cmd := &cobra.Command{ @@ -146,7 +151,7 @@ func StartBuilder() *cobra.Command { return opts.Run(cmd.Context()) }, PostRunE: func(_ *cobra.Command, _ []string) error { - return opts.PostRunMessages() + return opts.PostRun() }, } diff --git a/internal/cli/deployments/start_test.go b/internal/cli/deployments/start_test.go index 9cfe6b20c1..c21759e2dd 100644 --- a/internal/cli/deployments/start_test.go +++ b/internal/cli/deployments/start_test.go @@ -186,6 +186,27 @@ func TestStart_RunAtlas(t *testing.T) { t.Log(buf.String()) } +func TestStartOpts_PostRun(t *testing.T) { + ctrl := gomock.NewController(t) + deploymentsTest := fixture.NewMockLocalDeploymentOpts(ctrl, "localDeployment") + buf := new(bytes.Buffer) + + opts := &StartOpts{ + DeploymentOpts: *deploymentsTest.Opts, + OutputOpts: cli.OutputOpts{ + OutWriter: buf, + }, + } + + deploymentsTest. + MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) + + require.NoError(t, opts.PostRun()) +} + func TestStartBuilder(t *testing.T) { test.CmdValidator( t, diff --git a/internal/cli/deployments/test/fixture/deployment_atlas.go b/internal/cli/deployments/test/fixture/deployment_atlas.go index 2f26c8c883..35001008b8 100644 --- a/internal/cli/deployments/test/fixture/deployment_atlas.go +++ b/internal/cli/deployments/test/fixture/deployment_atlas.go @@ -25,16 +25,19 @@ import ( func NewMockAtlasDeploymentOpts(ctrl *gomock.Controller, deploymentName string) MockDeploymentOpts { mockCredentialsGetter := mocks.NewMockCredentialsGetter(ctrl) mockAtlasClusterListStore := mocks.NewMockClusterLister(ctrl) + mockDeploymentTelemetry := mocks.NewMockDeploymentTelemetry(ctrl) return MockDeploymentOpts{ ctrl: ctrl, MockCredentialsGetter: mockCredentialsGetter, MockAtlasClusterListStore: mockAtlasClusterListStore, + MockDeploymentTelemetry: mockDeploymentTelemetry, Opts: &options.DeploymentOpts{ CredStore: mockCredentialsGetter, AtlasClusterListStore: mockAtlasClusterListStore, DeploymentName: deploymentName, DeploymentType: "atlas", + DeploymentTelemetry: mockDeploymentTelemetry, }, } } @@ -65,4 +68,9 @@ func (m *MockDeploymentOpts) CommonAtlasMocks(projectID string) { ProjectClusters(projectID, gomock.Any()). Return(m.MockPaginatedAdvancedClusterDescription(), nil). Times(1) + + m.MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) } diff --git a/internal/cli/deployments/test/fixture/deployment_local.go b/internal/cli/deployments/test/fixture/deployment_local.go index 8873b03392..8cb39074cf 100644 --- a/internal/cli/deployments/test/fixture/deployment_local.go +++ b/internal/cli/deployments/test/fixture/deployment_local.go @@ -51,6 +51,11 @@ func (m *MockDeploymentOpts) LocalMockFlowWithMockContainer(ctx context.Context, ListContainers(ctx, options.MongodHostnamePrefix). Return(mockContainer, nil). Times(1) + + m.MockDeploymentTelemetry. + EXPECT(). + AppendDeploymentType(). + Times(1) } func (m *MockDeploymentOpts) LocalMockFlow(ctx context.Context) {