From c296a2ba198fa3544406ffd7d48312e78ab03bc3 Mon Sep 17 00:00:00 2001
From: Bianca Lisle <40155621+blva@users.noreply.github.com>
Date: Tue, 19 Mar 2024 16:06:23 +0000
Subject: [PATCH] fix: only attach error to diagnostics if podman machine is
 required (#2783)

---
 internal/podman/client.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/internal/podman/client.go b/internal/podman/client.go
index 43f26b7aa0..f3c713a19c 100644
--- a/internal/podman/client.go
+++ b/internal/podman/client.go
@@ -181,7 +181,9 @@ func (o *client) Diagnostics(ctx context.Context) *Diagnostic {
 	info, err := o.machineInspect(ctx)
 	if err != nil {
 		d.MachineFound = false
-		d.Errors = append(d.Errors, fmt.Errorf("failed to detect podman machine: %w", err).Error())
+		if d.MachineRequired {
+			d.Errors = append(d.Errors, fmt.Sprintf("failed to detect podman machine: %s", err))
+		}
 	} else {
 		d.MachineInfo = info
 		d.MachineState = info.State