From a0302aaf1d4b1525a4c1827fccfeeb7e8de6b551 Mon Sep 17 00:00:00 2001 From: Filipe C Menezes Date: Tue, 19 Mar 2024 10:24:53 +0000 Subject: [PATCH] CLOUDP-238518: Windows binaries are not signed --- build/ci/release.yml | 3 ++- build/package/download-win-binaries.sh | 11 +++++++---- build/package/windows_notarize.sh | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/build/ci/release.yml b/build/ci/release.yml index 05c4699b2f..651afaf027 100644 --- a/build/ci/release.yml +++ b/build/ci/release.yml @@ -246,10 +246,11 @@ tasks: local_files_include_filter: - src/github.com/mongodb/mongodb-atlas-cli/bin/*.exe - src/github.com/mongodb/mongodb-atlas-cli/dist/*.msi - remote_file: ${project}/dist/${revision}_${created_at}/ + remote_file: ${project}/dist/${revision}_${created_at}/unsigned_ bucket: mongodb-mongocli-build permissions: public-read content_type: ${content_type|application/octet-stream} + display_name: unsigned - name: package_goreleaser tags: ["packaging"] depends_on: diff --git a/build/package/download-win-binaries.sh b/build/package/download-win-binaries.sh index a4e8556779..e4c7326275 100755 --- a/build/package/download-win-binaries.sh +++ b/build/package/download-win-binaries.sh @@ -28,10 +28,13 @@ fi PACKAGE_NAME="mongocli_${VERSION_NAME}_windows_x86_64.msi" BINARY_NAME="mongocli.exe" +PACKAGE_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${PACKAGE_NAME} +BINARY_URL=https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/unsigned_${BINARY_NAME} + pushd bin -echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME} into $PWD" -curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${PACKAGE_NAME}" --output "${PACKAGE_NAME}" +echo "downloading $PACKAGE_URL into $PWD/$PACKAGE_NAME" +curl "$PACKAGE_URL" --output "${PACKAGE_NAME}" -echo "downloading https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME} into $PWD" -curl "https://${BUCKET}.s3.amazonaws.com/${project}/dist/${revision}_${created_at}/${BINARY_NAME}" --output "${BINARY_NAME}" +echo "downloading $BINARY_URL into $PWD/$BINARY_NAME" +curl "$BINARY_URL" --output "${BINARY_NAME}" diff --git a/build/package/windows_notarize.sh b/build/package/windows_notarize.sh index b3c65beda7..de58bee9dc 100755 --- a/build/package/windows_notarize.sh +++ b/build/package/windows_notarize.sh @@ -16,7 +16,7 @@ set -Eeou pipefail -EXE_FILE="dist/windows_windows_amd64_v1/bin/mongocli.exe" +EXE_FILE="bin/mongocli.exe" MSI_FILE="bin/mongocli_${VERSION}_windows_x86_64.msi" if [[ -f "$EXE_FILE" && -f "$MSI_FILE" ]]; then