From b615df180c77d0f3111579f3140577f7f69f83ab Mon Sep 17 00:00:00 2001 From: Gustavo Bazan Date: Fri, 22 Mar 2024 11:54:18 +0000 Subject: [PATCH] task: use the recommended slice initialization --- internal/cli/atlas/datalakepipelines/create.go | 6 +++--- internal/cli/atlas/datalakepipelines/update.go | 6 +++--- internal/cli/atlas/security/ldap/save.go | 2 +- internal/cli/atlas/serverless/create.go | 2 +- internal/cli/atlas/serverless/update.go | 2 +- internal/cli/atlas/setup/cluster_setup.go | 2 +- internal/kubernetes/operator/project/project.go | 2 +- internal/podman/client.go | 3 +-- 8 files changed, 12 insertions(+), 13 deletions(-) diff --git a/internal/cli/atlas/datalakepipelines/create.go b/internal/cli/atlas/datalakepipelines/create.go index fe246af318..88878bca36 100644 --- a/internal/cli/atlas/datalakepipelines/create.go +++ b/internal/cli/atlas/datalakepipelines/create.go @@ -114,13 +114,13 @@ func (opts *CreateOpts) newCreateRequest() (*atlasv2.DataLakeIngestionPipeline, }, } - partitionFields := []atlasv2.DataLakePipelinesPartitionField{} + partitionFields := make([]atlasv2.DataLakePipelinesPartitionField, len(opts.sinkPartitionField)) for i, fieldName := range opts.sinkPartitionField { - partitionFields = append(partitionFields, *atlasv2.NewDataLakePipelinesPartitionField(fieldName, i)) + partitionFields[i] = *atlasv2.NewDataLakePipelinesPartitionField(fieldName, i) } pipeline.Sink.SetPartitionFields(partitionFields) - transformations := []atlasv2.FieldTransformation{} + var transformations []atlasv2.FieldTransformation for _, entry := range opts.transform { entries := strings.Split(entry, ":") transformType := entries[0] diff --git a/internal/cli/atlas/datalakepipelines/update.go b/internal/cli/atlas/datalakepipelines/update.go index 237b87a0bd..b52eb7dfd9 100644 --- a/internal/cli/atlas/datalakepipelines/update.go +++ b/internal/cli/atlas/datalakepipelines/update.go @@ -108,13 +108,13 @@ func (opts *UpdateOpts) newUpdateRequest() (*atlasv2.DataLakeIngestionPipeline, }, } - partitionFields := []atlasv2.DataLakePipelinesPartitionField{} + partitionFields := make([]atlasv2.DataLakePipelinesPartitionField, len(opts.sinkPartitionField)) for i, fieldName := range opts.sinkPartitionField { - partitionFields = append(partitionFields, *atlasv2.NewDataLakePipelinesPartitionField(fieldName, i)) + partitionFields[i] = *atlasv2.NewDataLakePipelinesPartitionField(fieldName, i) } pipeline.Sink.SetPartitionFields(partitionFields) - transformations := []atlasv2.FieldTransformation{} + var transformations []atlasv2.FieldTransformation for _, entry := range opts.transform { entries := strings.Split(entry, ":") transformType := entries[0] diff --git a/internal/cli/atlas/security/ldap/save.go b/internal/cli/atlas/security/ldap/save.go index 78a1ef7067..f7cabfe636 100644 --- a/internal/cli/atlas/security/ldap/save.go +++ b/internal/cli/atlas/security/ldap/save.go @@ -97,7 +97,7 @@ func (opts *SaveOpts) validate() error { } func (opts *SaveOpts) newLDAPConfiguration() *atlasv2.UserSecurity { - userToDNMapping := []atlasv2.UserToDNMapping{} + var userToDNMapping []atlasv2.UserToDNMapping if opts.mappingMatch != "" { mapping := atlasv2.UserToDNMapping{Match: opts.mappingMatch} if opts.mappingLdapQuery != "" { diff --git a/internal/cli/atlas/serverless/create.go b/internal/cli/atlas/serverless/create.go index 40a66d984d..00d30058f4 100644 --- a/internal/cli/atlas/serverless/create.go +++ b/internal/cli/atlas/serverless/create.go @@ -73,7 +73,7 @@ func (opts *CreateOpts) newServerlessCreateRequestParams() *atlasv2.ServerlessIn } if len(opts.tag) > 0 { - tags := []atlasv2.ResourceTag{} + var tags []atlasv2.ResourceTag for k, v := range opts.tag { if k != "" && v != "" { tags = append(tags, atlasv2.ResourceTag{Key: k, Value: v}) diff --git a/internal/cli/atlas/serverless/update.go b/internal/cli/atlas/serverless/update.go index 11ab1901e1..a682923d55 100644 --- a/internal/cli/atlas/serverless/update.go +++ b/internal/cli/atlas/serverless/update.go @@ -71,7 +71,7 @@ func (opts *UpdateOpts) newServerlessUpdateRequestParams() *atlasv2.ServerlessIn } if len(opts.tag) > 0 { - tags := []atlasv2.ResourceTag{} + var tags []atlasv2.ResourceTag for k, v := range opts.tag { if k != "" && v != "" { tags = append(tags, atlasv2.ResourceTag{Key: k, Value: v}) diff --git a/internal/cli/atlas/setup/cluster_setup.go b/internal/cli/atlas/setup/cluster_setup.go index 4cec4a4cb1..a1270f9057 100644 --- a/internal/cli/atlas/setup/cluster_setup.go +++ b/internal/cli/atlas/setup/cluster_setup.go @@ -107,7 +107,7 @@ func (opts *Opts) newCluster() *atlasv2.AdvancedClusterDescription { } if len(opts.Tag) > 0 { - tags := []atlasv2.ResourceTag{} + var tags []atlasv2.ResourceTag for k, v := range opts.Tag { if k != "" && v != "" { tags = append(tags, atlasv2.ResourceTag{Key: k, Value: v}) diff --git a/internal/kubernetes/operator/project/project.go b/internal/kubernetes/operator/project/project.go index 48e1300c16..d79047e6f3 100644 --- a/internal/kubernetes/operator/project/project.go +++ b/internal/kubernetes/operator/project/project.go @@ -817,7 +817,7 @@ func buildAlertConfigurations(acProvider store.AlertConfigurationLister, project return akoNotifications, akoSecrets } - secretResults := []*corev1.Secret{} + var secretResults []*corev1.Secret results := make([]akov2.AlertConfiguration, 0, len(data.GetResults())) for _, alertConfig := range data.GetResults() { notifications, notificationSecrets := convertNotifications(alertConfig.GetNotifications()) diff --git a/internal/podman/client.go b/internal/podman/client.go index f3c713a19c..9a67a831fc 100644 --- a/internal/podman/client.go +++ b/internal/podman/client.go @@ -482,8 +482,7 @@ func (o *client) Version(ctx context.Context) (version *Version, err error) { func (o *client) Logs(ctx context.Context) (map[string]interface{}, []error) { l := map[string]interface{}{} - errs := []error{} - + var errs []error output, err := o.runPodman(ctx, "ps", "--all", "--format", "json", "--filter", "name=mongo") if err != nil { errs = append(errs, err)