fix: session support detection spec compliance #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
reviewed
Feb 8, 2021
test/unit/core/common.js
Outdated
| }); | ||
|
|
||
| this.defineReplSetStates(); | ||
| // this.configureMessageHandlers(); |
There was a problem hiding this comment.
Should this line be commented out? Seems there are some issues in CI.
There was a problem hiding this comment.
Whoops good catch, let's see if the commit I just pushed fixes it. I made the change on the 4.0 port already to add if statements to gate these extra setup calls.
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on a help ticket the reduce callback in the topology description
doesn't correctly return null if it's in the middle of the list of servers.