Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3252): state transistion from DISCONNECTED #2807

Merged
merged 1 commit into from May 17, 2021
Merged

fix(NODE-3252): state transistion from DISCONNECTED #2807

merged 1 commit into from May 17, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 12, 2021 •
edited

Change the state change to a legal transition

@nbbeeken nbbeeken requested review from a team, durran, emadum and dariakp and removed request for a team May 13, 2021 17:42
@nbbeeken nbbeeken marked this pull request as ready for review May 13, 2021 17:42
dariakp
dariakp approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it would have been nice to have tests for this that aren't disabled

@nbbeeken nbbeeken merged commit 5d8f649 into 3.6 May 17, 2021
@nbbeeken nbbeeken deleted the NODE-3252/state-transition branch May 17, 2021 18:41
@nbbeeken
Copy link
Contributor Author

Made NODE-3289 for us to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@dariakp dariakp dariakp approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nbbeeken @emadum @dariakp