fix(NODE-3386): listCollections result type definition #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fwiw, it can come pretty close: TypeScript playground |
|
Oo thanks for the insight, I'll give that a try |
addaleax
approved these changes
Jun 29, 2021
emadum
added
the
Primary Review
emadum
added
Team Review
dariakp
requested changes
Jul 8, 2021
Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
nbbeeken
force-pushed
the
NODE-3386/listCollectionsTypes
branch
from
d008033
to
b7c35cb
Compare
|
Rebased, should clear up the unrelated error in the last CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listCollections cursor now has a generic that defaults to a flexible CollectionInfo type. Typescript can't change a return type bases on a runtime boolean so I show example usage in the added types test of how one can use the API pretty succinctly.