New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-1843): bulk operations ignoring provided sessions #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jul 2, 2021
nbbeeken
force-pushed
the
NODE-1843/bulk-session
branch
from
July 2, 2021 18:30
5bad5e9
to
e2607ce
Compare
emadum
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm sure I've seen client.close
working in after hooks before without triggering the leak checker...
emadum
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Jul 2, 2021
…d for multi doc transaction
nbbeeken
force-pushed
the
NODE-1843/bulk-session
branch
from
July 2, 2021 19:35
e2607ce
to
df3064b
Compare
dariakp
requested changes
Jul 6, 2021
dariakp
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BulkOperationBase class wasn't making use of the options provided at construction time during execution time.
NODE-1843