Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-1843): bulk operations ignoring provided sessions #2868

Merged
merged 6 commits into from Jul 8, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 30, 2021

The BulkOperationBase class wasn't making use of the options provided at construction time during execution time.

NODE-1843

@emadum emadum self-requested a review July 2, 2021 18:01
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 2, 2021
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm sure I've seen client.close working in after hooks before without triggering the leak checker...

@emadum emadum requested a review from durran July 2, 2021 19:07
@emadum emadum added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 2, 2021
test/functional/bulk.test.js Outdated Show resolved Hide resolved
test/functional/bulk.test.js Outdated Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from dariakp July 7, 2021 17:28
@nbbeeken nbbeeken removed the request for review from durran July 8, 2021 15:05
@emadum emadum merged commit 70810d1 into 4.0 Jul 8, 2021
@emadum emadum deleted the NODE-1843/bulk-session branch July 8, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants