Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3095): add timeseries options to db.createCollection #2878

Merged
merged 3 commits into from Jul 8, 2021
Merged

feat(NODE-3095): add timeseries options to db.createCollection #2878

merged 3 commits into from Jul 8, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jul 2, 2021

No description provided.

@emadum emadum force-pushed the NODE-3095/4.0/create-timeseries-collection branch from 2b99dec to 0784c95 Compare July 2, 2021 17:17
@emadum emadum requested a review from nbbeeken July 2, 2021 17:58
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 2, 2021
nbbeeken
nbbeeken requested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS suggestion, what do you think?

src/operations/create_collection.ts Outdated Show resolved Hide resolved
@emadum emadum requested a review from nbbeeken July 2, 2021 20:01
nbbeeken
nbbeeken approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 6, 2021
@nbbeeken nbbeeken requested a review from dariakp July 6, 2021 14:17
dariakp
dariakp reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor suggestion

test/functional/collection_management_spec.test.js Show resolved Hide resolved
@nbbeeken nbbeeken merged commit c145c91 into 4.0 Jul 8, 2021
@nbbeeken nbbeeken deleted the NODE-3095/4.0/create-timeseries-collection branch July 8, 2021 15:58
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
feat(NODE-3095): add timeseries options to db.createCollection (#2878)
1bee7ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@emadum @nbbeeken @dariakp