Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3403): define MongoRuntimeError children #2894

Merged
merged 2 commits into from Jul 9, 2021
Merged

feat(NODE-3403): define MongoRuntimeError children #2894

merged 2 commits into from Jul 9, 2021

Conversation

W-A-James
Copy link
Contributor

Description

Added:

  • MongoBatchReExecutionError
  • MongoNotConnectedError
  • MongoCursorError
    • MongoCursorExhaustedError
    • MongoTailableCursorError
    • MongoCursorInUseError

What changed?

  • src/error.ts

@W-A-James
feat: Add new Error classess
a1181a6 
Add:

- MongoBatchReExecutionError
- MongoNotConnectedError
- MongoCursorError
  - MongoCursorExhaustedError
  - MongoTailableCursorError
  - MongoCursorInUseError
@W-A-James W-A-James changed the title feat(NODE-3403): Implement MongoRuntimeError children pt1 feat(NODE-3403): Define MongoRuntimeError children pt1 Jul 8, 2021
@W-A-James W-A-James requested a review from andymina July 8, 2021 19:33
andymina
andymina approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@andymina andymina left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work 👍🏾

@andymina andymina added the Team Review Needs review from team label Jul 8, 2021
emadum
emadum approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod the capitalization nit 👍

src/error.ts Outdated Show resolved Hide resolved
@andymina @emadum
docs(NODE-3403): fixes typo in MongoNotConnectedError
98e0005 
Co-authored-by: Eric Adum <eric.adum@mongodb.com>
@andymina andymina changed the title feat(NODE-3403): Define MongoRuntimeError children pt1 feat(NODE-3403): define MongoRuntimeError children Jul 9, 2021
@andymina andymina merged commit cb0db49 into 4.0 Jul 9, 2021
@andymina andymina deleted the NODE-3403/4.0/Implement-MongoRuntimeError-children branch July 9, 2021 21:14
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@W-A-James @ljhaywar
feat(NODE-3403): define MongoRuntimeError children (#2894)
be6d445 
- MongoBatchReExecutionError
- MongoNotConnectedError
- MongoCursorError
  - MongoCursorExhaustedError
  - MongoTailableCursorError
  - MongoCursorInUseError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@andymina andymina andymina approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
5 participants
@W-A-James @emadum @nbbeeken @andymina @dariakp