Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3279): use "hello" for monitoring if supported #2895

Merged
merged 6 commits into from Jul 12, 2021
Merged

fix(NODE-3279): use "hello" for monitoring if supported #2895

merged 6 commits into from Jul 12, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jul 8, 2021 •
edited

@emadum emadum added the wip label Jul 8, 2021
nbbeeken
nbbeeken approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum removed the wip label Jul 9, 2021
@emadum emadum marked this pull request as ready for review July 9, 2021 16:09
@emadum emadum changed the title fix(NODE-3279): helloOk support fix(NODE-3279): use "hello" command for monitoring if supported Jul 9, 2021
@emadum emadum changed the title fix(NODE-3279): use "hello" command for monitoring if supported fix(NODE-3279): use "hello" for monitoring if supported Jul 9, 2021
@emadum emadum added the Team Review Needs review from team label Jul 9, 2021
@emadum emadum requested review from dariakp and durran July 9, 2021 16:15
@nbbeeken nbbeeken merged commit 5a8842a into 4.0 Jul 12, 2021
@nbbeeken nbbeeken deleted the NODE-3279/4.0/helloOk-support branch July 12, 2021 20:15
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
fix(NODE-3279): use "hello" for monitoring if supported (#2895)
d3ce523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@emadum @nbbeeken @dariakp