Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3546): revert findOne not found result type to null #2945

Merged
merged 2 commits into from Aug 24, 2021

Conversation

nbbeeken
Copy link
Contributor

findOne will now return null
ModifyResult correctly types value to be null or TSchema

@dariakp dariakp added the Team Review Needs review from team label Aug 24, 2021
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dariakp dariakp merged commit 1c576e9 into 4.1 Aug 24, 2021
@dariakp dariakp deleted the NODE-3546/findOne-null branch August 24, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants