feat(NODE-3424): use hello for monitoring commands #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-3424/useHello
branch
2 times, most recently
from
5a4fcd6
to
4d22eb3
Compare
nbbeeken
force-pushed
the
NODE-3424/useHello
branch
from
4d22eb3
to
2e19107
Compare
dariakp
requested changes
Sep 10, 2021
|
Ok now this is ready if CI passes, sorry for all the rapid patches @dariakp |
dariakp
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes use of the helloOk property in hello handshakes
the specs are brought in, in a seperate commit so should be able to filter on that.
Had to skip one test for the legacy topology state machine:
Repeated isWritablePrimary response must be processed