Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3691): make time series options granularity type strict #3005

Merged
merged 3 commits into from Oct 24, 2021
Merged

feat(NODE-3691): make time series options granularity type strict #3005

merged 3 commits into from Oct 24, 2021

Conversation

zerefdev
Copy link
Contributor

What is changing?

Type for timeseries granularity

Is there new documentation needed for these changes?

No

What is the motivation for this change?

IDE autocompletion, typo prevention.

@durran durran self-assigned this Oct 19, 2021
@durran durran added Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira Ticket filed in MongoDB's Jira system labels Oct 19, 2021
@durran durran changed the title feat(typescript): proper granularity type feat(NODE-3691): proper granularity type Oct 19, 2021
@durran durran changed the title feat(NODE-3691): proper granularity type feat(NODE-3691): make time series options granularity type strict Oct 19, 2021
@durran durran self-requested a review October 19, 2021 21:51
@durran durran removed their assignment Oct 19, 2021
@durran durran requested review from a team, gjchong25, mongo-node-bot, nbbeeken and dariakp and removed request for a team, gjchong25 and mongo-node-bot October 19, 2021 21:51
@durran durran added Team Review Needs review from team Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team labels Oct 19, 2021
@durran durran requested review from durran and removed request for nbbeeken and dariakp October 19, 2021 23:03
durran
durran requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one formatting change.

src/operations/create_collection.ts Outdated Show resolved Hide resolved
@durran durran self-requested a review October 20, 2021 19:12
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 21, 2021
@durran durran requested review from dariakp and durran October 21, 2021 13:55
dariakp
dariakp requested changes Oct 22, 2021
View reviewed changes
src/operations/create_collection.ts Outdated Show resolved Hide resolved
@zerefdev @dariakp
keep "string" type
50adc82 
Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
@dariakp dariakp changed the base branch from 4.1 to main October 22, 2021 21:26
dariakp
dariakp approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerefdev thanks for addressing the feedback so quickly; I've also repointed the PR to main because as a "feature", this should go into our next minor version (4.2) instead of the current 4.1

@zerefdev
Copy link
Contributor Author

Great! Thank you

@durran durran merged commit 7111d9a into mongodb:main Oct 24, 2021
dariakp added a commit that referenced this pull request Nov 2, 2021
@zerefdev @dariakp
feat(NODE-3691): make time series options granularity type strict (#3005
98017f9 
)

* feat(typescript): proper granularity type

Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@zerefdev @dariakp @ljhaywar
feat(NODE-3691): make time series options granularity type strict (#3005
12318d0 
)

* feat(typescript): proper granularity type

Co-authored-by: Daria Pardue <81593090+dariakp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
Milestone
No milestone
3 participants
@zerefdev @durran @dariakp