fix(NODE-3344): allow setting defaultTransactionOptions with POJO rather than ReadConcern instance
#3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dariakp
requested changes
Nov 9, 2021
dariakp
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: Automattic/mongoose#10805
Description
Right now,
startSession({ defaultTransactionOptions: { readConcern: { level: 'snapshot' } } })fails to compile with aProperty 'toJSON' is missing in type '{ level: string; }' but required in type 'ReadConcern'.error. This seems like something that should change.What is changing?
TransactionOptions.readConcernis now aReadConcernLike, which allows using strings or{ level }object.Is there new documentation needed for these changes?
What is the motivation for this change?
Make
TransactionOptionsmore user-friendly and line up withCursor#withReadConcern()andCollectionOptions.Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>