Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3446): deprecate mapReduce command #3036

Merged
merged 1 commit into from Nov 11, 2021

Conversation

ljhaywar
Copy link
Contributor

Description

NODE-3446

What is changing?

The mapReduce command is being deprecated.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

This command predates our aggregation framework and have functionality which is superseded by the aggregate command. We do not intend to add it into the stable API and instead should deprecate it to preserve a smaller and more consistent API going forward.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@ljhaywar ljhaywar self-assigned this Nov 10, 2021
@ljhaywar
Copy link
Contributor Author

This is ready for review. I labeled this as "feat" as it seemed the best option. Should I label this as something else?

Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! As far as the commit type - I think feat: makes the most sense, but I've also added it to our next tech chat agenda to see if we're onboard with codifying this

@dariakp dariakp added the Team Review Needs review from team label Nov 11, 2021
@dariakp dariakp merged commit b6c73bf into main Nov 11, 2021
@dariakp dariakp deleted the NODE-3446/deprecate-mapReduce branch November 11, 2021 15:55
@ljhaywar
Copy link
Contributor Author

Thanks, @dariakp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants