Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-3793): Remove offensive language from code and tests #3082

Merged
merged 16 commits into from Dec 17, 2021

Conversation

ljhaywar
Copy link
Contributor

@ljhaywar ljhaywar commented Dec 14, 2021

Description

NODE-3793

What is changing?

Remove and deprecate (when removal is not possible) all references to "slaveOk" in the source code and tests. Note that spec test updates are being tracked in NODE-3791

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Following the guidance documented in tools.ietf.org/id/draft-knodel-terminology-00.html, we will remove all oppressive and unnecessarily gendered language in driver documentation, code, tests, specs, and spec tests.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests. I'm unsure and have commented below
  • New TODOs have a related JIRA ticket

@ljhaywar ljhaywar added the wip label Dec 14, 2021
@ljhaywar ljhaywar self-assigned this Dec 14, 2021
@ljhaywar
Copy link
Contributor Author

ljhaywar commented Dec 15, 2021

General question: Are these changes covered by tests? I tried changing the return value of slaveOk() in db.ts to both true and false (instead of this.secondaryOk;) and all of the tests passed. I did the same for slaveOk() in read_preferences and the tests continued passing. It seems odd that these changes wouldn't be covered at least indirectly by tests.

@ljhaywar ljhaywar changed the title NODE-3793 feat(NODE-3793): Remove offensive language from code and tests Dec 15, 2021
@ljhaywar ljhaywar removed the wip label Dec 15, 2021
@ljhaywar ljhaywar marked this pull request as ready for review December 15, 2021 18:03
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just capturing this particular thought for now, not a full review

src/collection.ts Outdated Show resolved Hide resolved
test/unit/db.test.ts Outdated Show resolved Hide resolved
@dariakp dariakp added the Team Review Needs review from team label Dec 17, 2021
@ljhaywar ljhaywar added the wip label Dec 17, 2021
@ljhaywar
Copy link
Contributor Author

Going to add a few more tests. Will comment here when I'm done

@ljhaywar
Copy link
Contributor Author

I've finished adding tests. This is ready for review.

@ljhaywar ljhaywar removed the wip label Dec 17, 2021
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@dariakp dariakp merged commit 91a67e0 into main Dec 17, 2021
@dariakp dariakp deleted the NODE-3793/rename-to-secondaryok branch December 17, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
4 participants