Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3792): remove offensive language throughout the codebase #3091

Merged
merged 16 commits into from Jan 12, 2022

Conversation

ljhaywar
Copy link
Contributor

@ljhaywar ljhaywar commented Jan 5, 2022

Description

Remove references to "master" throughout the codebase

What is changing?

  • Any references to master that can be updated are updated or abstracted to a constant
  • Any references to master that cannot be updated are deprecated
  • Exceptions:
    • CSFLE references to masterKey are out of scope
    • Historical documentation (e.g. history.md and changes_x.md) can remain as-is
    • References to GitHub repos with master branches
    • Spec tests are covered in NODE-3791
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Following the guidance documented in tools.ietf.org/id/draft-knodel-terminology-00.html, we will remove all oppressive and unnecessarily gendered language in driver documentation, code, tests, specs, and spec tests.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@ljhaywar ljhaywar added the wip label Jan 5, 2022
@ljhaywar ljhaywar self-assigned this Jan 5, 2022
src/cmap/connect.ts Outdated Show resolved Hide resolved
@ljhaywar ljhaywar changed the title NODE-3792 (wip) <feat>NODE-3792: remove offensive language throughout the codebase Jan 7, 2022
@ljhaywar ljhaywar changed the title <feat>NODE-3792: remove offensive language throughout the codebase feat(NODE-3792): remove offensive language throughout the codebase Jan 7, 2022
@ljhaywar ljhaywar removed the wip label Jan 7, 2022
@ljhaywar
Copy link
Contributor Author

ljhaywar commented Jan 7, 2022

This is ready for review. The build failures are all the Task Timeouts we've discussed. It would be good to get a second set of eyes to ensure I didn't change anything that should be deprecated instead.

@ljhaywar ljhaywar marked this pull request as ready for review January 7, 2022 17:06
src/sdam/monitor.ts Outdated Show resolved Hide resolved
src/sdam/monitor.ts Outdated Show resolved Hide resolved
src/cmap/connect.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added the Team Review Needs review from team label Jan 11, 2022
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all LGTM, really great job here @ljhaywar ! Just waiting on the tests to get sorted out :)

@ljhaywar
Copy link
Contributor Author

I reran the local patch from my machine with delete response[LEGACY_HELLO_COMMAND]; in the two places Neal suggested, and this time the build passed:
https://spruce.mongodb.com/version/61dec74b2a60ed5bf60f7889/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Maybe it was the mistake I made that Neal caught? Or maybe it was unrelated as I've been seeing the Context Cancelled errors sporadically in my builds and others'? Either way, I think we're good to go.

@nbbeeken nbbeeken changed the title feat(NODE-3792): remove offensive language throughout the codebase fix(NODE-3792): remove offensive language throughout the codebase Jan 12, 2022
@nbbeeken nbbeeken merged commit 8e2b0cc into main Jan 12, 2022
@nbbeeken nbbeeken deleted the NODE-3792/update-references-to-offensive-language branch January 12, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants