Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3852,NODE-3854,NODE-3856): Misc typescript fixes for 4.3.1 #3102

Merged
merged 14 commits into from Jan 14, 2022
Merged

fix(NODE-3852,NODE-3854,NODE-3856): Misc typescript fixes for 4.3.1 #3102

merged 14 commits into from Jan 14, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jan 11, 2022 •
edited

Description

This PR includes three Typescript fixes / improvements.

What is changing?

  1. NODE-3856 - allows users to user a document of their collection schema type as a filter in findX operations
  2. NODE-3854 - update the return types of findOneAnd<op> to include the _id field. The behavior of these functions is now aligned with the general findX methods
  3. NODE-3852 - Adds support for some recursive schemas
Is there new documentation needed for these changes?

Probably. I think we should document exactly what is and is not supported somewhere once we flesh out exactly what we're supporting and we're not supporting.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title WIP fix(NODE-3856): Misc typescript fixes for 4.3.1 fix(NODE-3856): Misc typescript fixes for 4.3.1 Jan 12, 2022
@baileympearson baileympearson marked this pull request as ready for review January 12, 2022 20:03
@dariakp dariakp changed the title fix(NODE-3856): Misc typescript fixes for 4.3.1 fix(NODE-3852,NODE-3854,NODE-3856): Misc typescript fixes for 4.3.1 Jan 12, 2022
@dariakp dariakp self-requested a review January 13, 2022 15:55
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 13, 2022
dariakp
dariakp requested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing from me, to make this easier to follow (and possibly amend later)

src/mongo_types.ts Outdated Show resolved Hide resolved
@baileympearson baileympearson mentioned this pull request Jan 14, 2022
Merged
8 tasks
@nbbeeken nbbeeken mentioned this pull request Jan 14, 2022
Closed
5 tasks
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 14, 2022
nbbeeken
nbbeeken approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dariakp dariakp merged commit dd5195a into main Jan 14, 2022
@dariakp dariakp deleted the NODE-3856-misc-typescript-fixes branch January 14, 2022 19:44
@alias-mac alias-mac mentioned this pull request Jan 17, 2022
Merged
@noahsilas noahsilas mentioned this pull request Jan 25, 2022
Closed
5 tasks
@vkarpov15 vkarpov15 mentioned this pull request Jan 27, 2022
Closed
@avaly avaly mentioned this pull request Feb 8, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@baileympearson @nbbeeken @dariakp