Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3351): use hostname canonicalization #3122

Merged
merged 10 commits into from Feb 8, 2022
Merged

feat(NODE-3351): use hostname canonicalization #3122

merged 10 commits into from Feb 8, 2022

Conversation

durran
Copy link
Member

@durran durran commented Feb 1, 2022

Description

Sets the driver to use the proper CANONICALIZE_HOST_NAME option when using Kerberos.

What is changing?

Removes the old check of gssapiCanonicalizeHostName to use the proper option. This was dead code as it was not a public member of our AuthMechanismProperties and was not parsed by the URI.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-3351

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran mentioned this pull request Feb 1, 2022
Closed
5 tasks
dariakp
dariakp requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things here

test/manual/kerberos.test.js Show resolved Hide resolved
test/manual/kerberos.test.js Outdated Show resolved Hide resolved
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 3, 2022
@durran durran requested a review from dariakp February 4, 2022 13:07
@durran durran mentioned this pull request Feb 4, 2022
Merged
5 tasks
dariakp
dariakp previously approved these changes Feb 7, 2022
View reviewed changes
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 7, 2022
nbbeeken
nbbeeken requested changes Feb 7, 2022
View reviewed changes
src/cmap/auth/gssapi.ts Show resolved Hide resolved
test/manual/kerberos.test.js Outdated Show resolved Hide resolved
@durran durran requested a review from nbbeeken February 8, 2022 14:35
nbbeeken
nbbeeken previously approved these changes Feb 8, 2022
View reviewed changes
@durran durran changed the title fix(NODE-3351): use hostname canonicalization feat(NODE-3351): use hostname canonicalization Feb 8, 2022
dariakp
dariakp approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dariakp dariakp merged commit f5c76f3 into main Feb 8, 2022
@dariakp dariakp deleted the NODE-3351 branch February 8, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@durran @nbbeeken @dariakp