fix(NODE-3878): use legacy count operation on collection.count #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-3878-Collection-count-use-legacy-op
branch
from
6fd7a74
to
03c34a0
Compare
nbbeeken
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
LGTM thanks!
cc: @addaleax Just want to this change on your radar, it's an (overdue) revert. The deprecated count method should've continued to use the deprecated count operation, there is no visible user facing changes, only performance and accuracy depending on deployment. It may be worth surfacing the change in shell change notes, but not essential
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR updates
Collection.countto use the legacy count operation. It also unskips tests that were failing whenCollection.countwas modified to use the new count operation.Is there new documentation needed for these changes?
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>