feat(NODE-2938): add service host mechanism property #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
durran
force-pushed
the
NODE-2938-gssapi-service-host
branch
from
747528b
to
1db60e7
Compare
dariakp
requested changes
Feb 9, 2022
dariakp
added
Team Review
nbbeeken
previously approved these changes
Feb 9, 2022
durran
force-pushed
the
NODE-2938-gssapi-service-host
branch
from
1db60e7
to
f0acf9c
Compare
dariakp
previously approved these changes
Feb 9, 2022
durran
force-pushed
the
NODE-2938-gssapi-service-host
branch
from
f0acf9c
to
1c3932b
Compare
dariakp
approved these changes
Feb 9, 2022
baileympearson
previously approved these changes
Feb 9, 2022
dariakp
requested changes
Feb 9, 2022
dariakp
approved these changes
Feb 10, 2022
dariakp
requested changes
Feb 10, 2022
dariakp
approved these changes
Feb 10, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
SERVICE_HOSTproperty to auth mechanisms for the kerberos auth case where a different host in the service principal name should be provided instead of the resolved host.What is changing?
Adds a
SERVICE_HOSTproperty and updates the tests to include it.This branch is rebased against #3122
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-2938
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>